Repository navigation
refactor(reliability)!: delete unconsumed reliability profiles module (LAB-6352) - #445
Conversation
… (LAB-6352) BREAKING CHANGE: removed the cachekit.reliability.profiles module: ReliabilityProfile, ProfileConfig, PROFILE_CONFIGS, get_profile_config, get_profile_description, recommend_profile, HIGH_THROUGHPUT_THRESHOLD_RPS and LOW_THROUGHPUT_THRESHOLD_RPS. cachekit.reliability no longer re-exports ReliabilityProfile, ProfileConfig, get_profile_config or recommend_profile. Nothing in cachekit read these values, so no runtime behaviour changes.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: cachekit-io/cachekit-py/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Deletes
cachekit.reliability.profilesand its test module. Nothing insrc/reads the module now that thecreate_decorator_configfamily is gone (#338). Its docstrings implied a runtime effect that no code path delivers, andrecommend_profile()returned advice that no API could apply.src/cachekit/reliability/profiles.pydeleted:ReliabilityProfile,ProfileConfig,PROFILE_CONFIGS,get_profile_config,get_profile_description,recommend_profile,HIGH_THROUGHPUT_THRESHOLD_RPSandLOW_THROUGHPUT_THRESHOLD_RPS.tests/critical/test_reliability_profiles.pydeleted. It only checked the constant table against itself.src/cachekit/reliability/__init__.pydrops the profiles import block and its four__all__entries, and its docstring no longer lists "reliability profiles".There is no deprecation alias. cachekit-py is pre-1.0, so this ships as a breaking minor through release-please.
Verification
uv run ruff check src/ tests/anduv run ruff format --check src/ tests/both pass.uv run pytest tests/unit tests/critical -m "not slow": 4038 passed, 25 skipped.uv run pytest --doctest-modules src/cachekit --ignore=src/cachekit/_rust_serializer.py: 110 passed, 14 skipped.python -c "import cachekit.reliability.profiles"raisesModuleNotFoundError, andfrom cachekit.reliability import ReliabilityProfileraisesImportError.src/ tests/ docs/ README.md llms.txtreturns nothing, and so does the same grep overcachekit-io/docsmain.Docs
No docs needed: no README,
docs/,llms.txtor docs-site page names the removed symbols. The "reliability profile" wording indocs/features/interop-mode.mddescribes an intent preset's reliability features, not this module, so it stays. release-please writes the CHANGELOG entry from the footer below.Migration
Nothing to migrate. No cachekit API consumed these values, so removing them changes no runtime behaviour. Configure reliability through the
@cacheintent presets orCircuitBreakerConfig.Closes LAB-6352
BEGIN_COMMIT_OVERRIDE
refactor(reliability)!: delete unconsumed reliability profiles module (LAB-6352) (#445)
BREAKING CHANGE: removed the cachekit.reliability.profiles module, with ReliabilityProfile, ProfileConfig, PROFILE_CONFIGS, get_profile_config, get_profile_description, recommend_profile, HIGH_THROUGHPUT_THRESHOLD_RPS and LOW_THROUGHPUT_THRESHOLD_RPS; cachekit.reliability no longer re-exports ReliabilityProfile, ProfileConfig, get_profile_config or recommend_profile. No cachekit API read these values, so no runtime behaviour changes.
END_COMMIT_OVERRIDE