Skip to content

refactor(reliability)!: delete unconsumed reliability profiles module (LAB-6352) - #445

Merged
27Bslash6 merged 3 commits into
mainfrom
lab-6352-delete-reliability-profiles
Oct 2, 2026
Merged

27Bslash6 merged 3 commits into
mainfrom
lab-6352-delete-reliability-profiles

Conversation

@27Bslash6

@27Bslash6 27Bslash6 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Deletes cachekit.reliability.profiles and its test module. Nothing in src/ reads the module now that the create_decorator_config family is gone (#338). Its docstrings implied a runtime effect that no code path delivers, and recommend_profile() returned advice that no API could apply.

  • src/cachekit/reliability/profiles.py deleted: ReliabilityProfile, ProfileConfig, PROFILE_CONFIGS, get_profile_config, get_profile_description, recommend_profile, HIGH_THROUGHPUT_THRESHOLD_RPS and LOW_THROUGHPUT_THRESHOLD_RPS.
  • tests/critical/test_reliability_profiles.py deleted. It only checked the constant table against itself.
  • src/cachekit/reliability/__init__.py drops the profiles import block and its four __all__ entries, and its docstring no longer lists "reliability profiles".

There is no deprecation alias. cachekit-py is pre-1.0, so this ships as a breaking minor through release-please.

Verification

  • uv run ruff check src/ tests/ and uv run ruff format --check src/ tests/ both pass.
  • uv run pytest tests/unit tests/critical -m "not slow": 4038 passed, 25 skipped.
  • uv run pytest --doctest-modules src/cachekit --ignore=src/cachekit/_rust_serializer.py: 110 passed, 14 skipped.
  • python -c "import cachekit.reliability.profiles" raises ModuleNotFoundError, and from cachekit.reliability import ReliabilityProfile raises ImportError.
  • A grep for every removed symbol over src/ tests/ docs/ README.md llms.txt returns nothing, and so does the same grep over cachekit-io/docs main.

Docs

No docs needed: no README, docs/, llms.txt or docs-site page names the removed symbols. The "reliability profile" wording in docs/features/interop-mode.md describes an intent preset's reliability features, not this module, so it stays. release-please writes the CHANGELOG entry from the footer below.

Migration

Nothing to migrate. No cachekit API consumed these values, so removing them changes no runtime behaviour. Configure reliability through the @cache intent presets or CircuitBreakerConfig.

Closes LAB-6352

BEGIN_COMMIT_OVERRIDE
refactor(reliability)!: delete unconsumed reliability profiles module (LAB-6352) (#445)

BREAKING CHANGE: removed the cachekit.reliability.profiles module, with ReliabilityProfile, ProfileConfig, PROFILE_CONFIGS, get_profile_config, get_profile_description, recommend_profile, HIGH_THROUGHPUT_THRESHOLD_RPS and LOW_THROUGHPUT_THRESHOLD_RPS; cachekit.reliability no longer re-exports ReliabilityProfile, ProfileConfig, get_profile_config or recommend_profile. No cachekit API read these values, so no runtime behaviour changes.
END_COMMIT_OVERRIDE

… (LAB-6352)

BREAKING CHANGE: removed the cachekit.reliability.profiles module: ReliabilityProfile, ProfileConfig, PROFILE_CONFIGS, get_profile_config, get_profile_description, recommend_profile, HIGH_THROUGHPUT_THRESHOLD_RPS and LOW_THROUGHPUT_THRESHOLD_RPS. cachekit.reliability no longer re-exports ReliabilityProfile, ProfileConfig, get_profile_config or recommend_profile. Nothing in cachekit read these values, so no runtime behaviour changes.
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: cachekit-io/cachekit-py/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1d48e027-46fd-44a8-a998-cfa76c999373

📥 Commits

Reviewing files that changed from the base of the PR and between b9ad394 and dcc7617.

📒 Files selected for processing (3)
  • src/cachekit/reliability/__init__.py
  • src/cachekit/reliability/profiles.py
  • tests/critical/test_reliability_profiles.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kodus-27b

kodus-27b Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the `@kody start-review` command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Providing Context (Files & MCPs)

Add these hints in your PR description (or a comment) to unlock deeper checks:

  • Ticket / Acceptance Criteria: `Refs: ABC-123` (Linear/Jira/Asana/ClickUp/Trello) or a direct ticket link.
  • Bugfix Validation: a Sentry/Datadog/Bugsnag event link (or paste the stack trace/error message).
  • Endpoint Risk: mention the route (e.g., `POST /api/payments`) or controller/action name.
  • Attach a repo file as context: use an explicit marker like `@file:docs/guide.mdx#L10-L50` (replace with your real path).
  • API Contract Docs: include `@file:openapi.yaml` or `@file:swagger.json` when changing routes/schemas.
  • Definition of Done / Standards: include `@file:DOD.md` or `@file:CONTRIBUTING.md` if your repo has them.
  • Design System Source of Truth: include `@file:ui/index.ts` (replace with your DS entrypoint path).
  • Feature Flags: include the flag key/name and `@file:flags.ts` / `@file:config.json` (and optionally the PostHog flag name).
  • Edge/CDN Rules: link the Cloudflare rule/zone or describe the intended redirect/header behavior.
  • Attach an MCP tool output: use `@mcp<provider|tool>` (replace with an installed MCP provider + tool, e.g., `@mcp<sentry|events.search>`).
Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@27Bslash6
27Bslash6 merged commit 0b71441 into main Oct 2, 2026
36 checks passed
@27Bslash6
27Bslash6 deleted the lab-6352-delete-reliability-profiles branch October 2, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant