Repository navigation
build(deps): 升级 loader 至 v0.5.3,交付 BSD mmap 修复 - #1006
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1006 +/- ##
==========================================
+ Coverage 51.86% 53.44% +1.57%
==========================================
Files 127 171 +44
Lines 10893 14171 +3278
==========================================
+ Hits 5650 7574 +1924
- Misses 4920 6502 +1582
+ Partials 323 95 -228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The dependency and checksum changes are consistent with the intended fix, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Updates Sonic’s loader dependency to deliver the BSD anonymous-memory mapping fix to Go Modules users.
Changes:
- Upgrades loader from v0.5.2 to v0.5.3.
- Synchronizes the dependency checksums.
| File | Description |
|---|---|
| go.sum | Updates checksums for loader v0.5.3. |
| go.mod | Requires loader v0.5.3 with the BSD fix. |
Review effort: Balanced
What type of PR is this?
build
Check the PR title.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
背景
#902 已将 BSD 匿名 mmap 的 fd 从
0修正为-1,并随 loader/v0.5.3 发布。主模块仍依赖loader v0.5.2,因此通过 Go Modules 使用 Sonic 的用户尚未获取到该修复。改动方案与影响范围
将主模块 loader 依赖升级到
v0.5.3,同步模块校验和。本次仅修改go.mod和go.sum;loader 的版本差异只有 mmap fd 修复及格式调整,public API 和 Go 版本要求保持不变。测试与验证
本机环境为 Linux/amd64,以下 11 组检查全部通过:
GOWORK=off go test -race -count=1 ./...,默认和 OptDec/FastMap/VM 两种模式。GOWORK=off go test -count=1 ./...,默认和 OptDec/FastMap/VM 两种模式。go test -race -count=1 ./issue_test ./generic_test,默认和 OptDec/FastMap/VM 两种模式。go test -count=1 ./compatibility/,覆盖默认/OptDec 与 jsonv2/nojsonv2 的四种组合;nojsonv2 下额外执行 issue suite。bash ./scripts/test_race.sh,确认预期的 race 仍能被检测到。回归子模块使用不包含
./loader的临时 workspace;主模块测试使用GOWORK=off。两种设置均通过go list -m确认实际加载发布版loader v0.5.3,避免本地 loader 覆盖依赖升级的验证。本次未在 BSD 主机执行运行测试。git diff --check和分支命名检查通过。(Optional) Which issue(s) this PR fixes:
Related to #902 and #962.