Log a concise warning instead of a full traceback when MSA search falls back - #328
Open
ssiddhantsharma wants to merge 1 commit into
Open
Conversation
…ls back When the MMseqs2 MSA server errors, the three fallback handlers in colab_request_parser.py caught the exception but printed the full traceback.format_exc(). The exception is handled (the run continues with a fallback), so dumping a full traceback makes a routine, recoverable event look like a fatal crash - confusing for users and noisy for log scanners. Print a single concise WARNING with the exception type/message instead, and drop the now-unused 'import traceback'. No behavioral change beyond log verbosity.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the MMseqs2 MSA server returns an error, the three fallback handlers in
protenix/web_service/colab_request_parser.pycatch the exception and thenprint(f"MMSEQS2 failed with the following error message:\n{traceback.format_exc()}").The exception is handled — the pipeline continues (e.g. using the query sequence as its own MSA), so nothing has actually crashed. But dumping a full
Traceback (most recent call last): ...to stderr makes this routine, recoverable event look like a fatal error. It is easy to misread as a crash, and it trips up log/CI scanners that flag on the stringTraceback.This PR replaces the full-traceback print in all three handlers with a single concise line, e.g.:
and drops the now-unused
import traceback.print-based logging style (no new logging dependency).