fix(moonbit): modernize generated bindings and cancellation primitives - #1715
Merged
alexcrichton merged 5 commits intoSep 21, 2026
Merged
alexcrichton merged 5 commits into
alexcrichton merged 5 commits into
Conversation
alexcrichton
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated MoonBit bindings use outdated suberror payload syntax and can exceed the compiler's per-segment line limit. The bundled async runtime also needs the upstream
cancel/nocancelprimitive migration.This updates suberror payloads and emits
///|before generated top-level declarations. The async runtime adopts cancellation effects while preserving terminal-event cleanup for component buffers and handles. Existing runtime fixtures exercise catch bypass, sticky cancellation, shielding, and cancellation throughTaskGroup.The warning cleanup retains derived trait methods as deprecated compatibility aliases for the
impl/extendtransition, emits FFI helpers only when needed, updates deprecated syntax, and keepsDebugcoverage while dropping deprecatedShowderivation from test defaults.The five commits separate syntax fixes, declaration boundaries, cancellation migration, and warning cleanup. Broader CM task cancellation semantics remain follow-up work.
MoonBit remains excluded from the current CI language matrix; enabling its codegen/runtime jobs is a separate follow-up.