Skip to content
This repository was archived by the owner on Jul 27, 2026. It is now read-only.

fix: write RFC 3339 timestamps to codex auth.json - #46

Merged
frostming merged 3 commits into
mainfrom
copilot/fix-auth-json-time-format
Apr 23, 2026
Merged

fix: write RFC 3339 timestamps to codex auth.json#46
frostming merged 3 commits into
mainfrom
copilot/fix-auth-json-time-format

Conversation

Copilot AI commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Convert expires_at and last_refresh to RFC 3339 strings in save_openai_codex_oauth_tokens
  • Update _parse_tokens to handle both RFC 3339 strings and legacy integer timestamps for backward compatibility
  • Run tests to verify changes (all 19 tests pass)
  • Fix import ordering to satisfy ruff linting (CI fix)

Copilot AI linked an issue Apr 17, 2026 that may be closed by this pull request
codex auth.json time format changed to RFC3339 #45
Closed
@frostming
fix: convert auth.json timestamps to RFC 3339 format for codex CLI co…
d659ad0 
…mpatibility

Agent-Logs-Url: https://github.com/bubbuild/republic/sessions/bec5de29-5d89-4de9-bea2-0ef97ad4cc65

Co-authored-by: frostming <16336606+frostming@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix codex auth.json time format to RFC3339 fix: write RFC 3339 timestamps to codex auth.json Apr 17, 2026
Copilot AI requested a review from frostming April 17, 2026 08:58
@frostming

frostming commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

@copilot please fix the CI failure

@frostming
fix: correct import order to satisfy ruff linting
a50988f 
Agent-Logs-Url: https://github.com/bubbuild/republic/sessions/d6003dfb-7a9b-4316-93cd-ad57d16d1673

Co-authored-by: frostming <16336606+frostming@users.noreply.github.com>

Copilot AI commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please fix the CI failure

Fixed in a50988f — the from datetime import datetime, timezone import was placed out of alphabetical order relative to the other from imports, causing ruff to fail. Moved it to the correct position (base64 → collections.abc → contextlib → dataclasses → datetime → …).

Copilot AI requested a review from frostming April 23, 2026 08:58
@frostming
frostming marked this pull request as ready for review April 23, 2026 09:00
@frostming
frostming merged commit 7cd49f4 into main Apr 23, 2026
12 checks passed
@frostming
frostming deleted the copilot/fix-auth-json-time-format branch April 23, 2026 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@frostming frostming frostming approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@frostming frostming

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

codex auth.json time format changed to RFC3339

2 participants

@frostming