Prevent ParseSamples errors from being hidden - #12
Open
carbocation wants to merge 1 commit into
Open
carbocation wants to merge 1 commit into
carbocation wants to merge 1 commit into
Conversation
field. So, if the last sample did not have errors, then no errors would be reported. This corrects that by accumulating all errors.
5 similar comments
Owner
|
this seems reasonable. can you resolve the conflicts? or has this been fixed in a more recent version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
header.ParseSamplesmethod overwrites the errors slice with every new sample. So, if the very last sample has no errors, thenheader.ParseSamplesreports that there was no error.This commit causes
header.ParseSamplesto accumulate all errors in sample parsing, permitting it to indicate if any sample was incorrectly parsed, rather than the current behavior which only tells you whether or not the last sample was incorrectly parsed.(Note: This came to my attention while troubleshooting what I think is an issue with my
io.Readerwrapper from #11 , which may be nulling out data as you had pointed out.)