Skip to content

Add Basic Pay Later Buttons - #1894

Merged
agedd merged 5 commits into
pay-later-button-featurefrom
updated-add-basic-pay-later-buttons
Oct 19, 2026
Merged

agedd merged 5 commits into
pay-later-button-featurefrom
updated-add-basic-pay-later-buttons

Conversation

@agedd

@agedd agedd commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

  • Add a basic Pay Later button to the existing payment button stack, following the same pattern as the PayPal and Venmo buttons.
image

AI Usage

Which AI Agent Was Used?

  • Copilot
  • Claude
  • Other (Type Name Here)

How was AI used?
brainstorming and cleanup

Estimated AI Code Contribution

  • less than 30%
  • 30 - 60%
  • 60 - 100%

Checklist

  • [ ] Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@agedd
agedd requested a review from a team as a code owner October 13, 2026 15:38

@buzzamus buzzamus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor nit on a typo and a general question

Comment thread Sources/BraintreeUIComponents/PayPalPayLaterButton.swift Outdated
Comment thread Sources/BraintreeUIComponents/PayPalPayLaterButton.swift Outdated
Comment thread Sources/BraintreeUIComponents/PayPalPayLaterButton.swift Outdated
var userPhoneNumber: BTPayPalPhoneNumber?

// MARK: - Public Properties
@_spi(BraintreeUIComponents) public var offerPayLater: Bool

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to ensure that offerPayLater is always true when passing in to use the button?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i believe the button needs offerPayLater to be true so it sets that on the request before starting checkout. the @_spi(BraintreeUIComponents) is mostly to allow BraintreeUIComponents to set this property without adding it to the public API for merchants.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing you had the same thoughts as me, but I don't necessarily like this, but I think it is better than breaking the pattern and creating the PayPalCheckoutRequest privately, so I think this makes sense given the pros and cons

agedd and others added 2 commits October 15, 2026 18:20
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@buzzamus buzzamus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread Sources/BraintreeUIComponents/PayPalPayLaterButton.swift
@agedd
agedd merged commit 36bac1f into pay-later-button-feature Oct 19, 2026
15 checks passed
@agedd
agedd deleted the updated-add-basic-pay-later-buttons branch October 19, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants