Repository navigation
Add Basic Pay Later Buttons - #1894
Conversation
This reverts commit b934ad1.
buzzamus
left a comment
There was a problem hiding this comment.
Looks good! Just some minor nit on a typo and a general question
| var userPhoneNumber: BTPayPalPhoneNumber? | ||
|
|
||
| // MARK: - Public Properties | ||
| @_spi(BraintreeUIComponents) public var offerPayLater: Bool |
There was a problem hiding this comment.
Is this to ensure that offerPayLater is always true when passing in to use the button?
There was a problem hiding this comment.
yes i believe the button needs offerPayLater to be true so it sets that on the request before starting checkout. the @_spi(BraintreeUIComponents) is mostly to allow BraintreeUIComponents to set this property without adding it to the public API for merchants.
There was a problem hiding this comment.
I am guessing you had the same thoughts as me, but I don't necessarily like this, but I think it is better than breaking the pattern and creating the PayPalCheckoutRequest privately, so I think this makes sense given the pros and cons
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Summary of changes
AI Usage
Which AI Agent Was Used?
How was AI used?
brainstorming and cleanup
Estimated AI Code Contribution
Checklist
[ ] Added a changelog entryAuthors