Skip to content

Tmt early exits - #2426

Merged
Johan-Liebert1 merged 2 commits into
bootc-dev:mainfrom
Johan-Liebert1:tmt-early-exits
Sep 1, 2026
Merged

Tmt early exits#2426
Johan-Liebert1 merged 2 commits into
bootc-dev:mainfrom
Johan-Liebert1:tmt-early-exits

Conversation

@Johan-Liebert1

Copy link
Copy Markdown
Collaborator

Since now we have skip_if_ostree we can remove early exits we had in
some tests

Since now we have `skip_if_ostree` we can remove early exits we had in
some tests

Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
@bootc-bot
bootc-bot Bot requested a review from ckyrouac September 1, 2026 04:42
@Johan-Liebert1

Copy link
Copy Markdown
Collaborator Author

Thanks @HarshwardhanPatil07 for the approval. I think you'll need to be an "official" reviewer for the approval to count

@HarshwardhanPatil07

Copy link
Copy Markdown
Contributor

@Johan-Liebert1 I think it isn't like that

As in Github actions i see it works.

@HarshwardhanPatil07

Copy link
Copy Markdown
Contributor

@Johan-Liebert1 Actually we should verify this. If someone merges this pr can see if it works.

@HarshwardhanPatil07

Copy link
Copy Markdown
Contributor

Maybe i can act like bridge, like if someone comes he can pass the pr and know someone has taken a look into code

@Johan-Liebert1
Johan-Liebert1 enabled auto-merge (rebase) September 1, 2026 08:16
@HarshwardhanPatil07

Copy link
Copy Markdown
Contributor

@Johan-Liebert1 it works right?

@Johan-Liebert1

Copy link
Copy Markdown
Collaborator Author

The thing is you need to have write access to this repo for your approval to count towards mergibility.

[HarshwardhanPatil07](https://github.com/HarshwardhanPatil07)
Approved these changes with read-only permissions

Maybe i can act like bridge, like if someone comes he can pass the pr and know someone has taken a look into code

absolutely

@cgwalters cgwalters left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Johan-Liebert1
Johan-Liebert1 merged commit 6caf6ca into bootc-dev:main Sep 1, 2026
53 checks passed
@cgwalters

Copy link
Copy Markdown
Collaborator

Maybe i can act like bridge, like if someone comes he can pass the pr and know someone has taken a look into code

Yes this is a thing I brought up a while ago the Rust @bors bot has a delegate= command which allows a maintainer to allow another person to approve a single PR. I really like this as it helps convert even "drive by" patch submitters into reviewers. I think we could do it with a GHA triggered by an issue comment that verifies the relationship (PR is approved by @otheruser, a maintainer added e.g. `/delegate @otheruser) and then has bootc-bot approve the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants