feat: support repeated -e/--env-file for merging multiple env files - #134
Merged
Merged
Conversation
Contributor
Author
Build failure is a transient NodeSource outage — not from this PRThe This is the base This PR is TypeScript-only (no Dockerfile changes):
|
BoldBlackBot
force-pushed
the
feat/repeatable-env-file
branch
3 times, most recently
from
August 3, 2026 13:31
7881797 to
5a54d77
Compare
BoldBlackBot
force-pushed
the
feat/repeatable-env-file
branch
5 times, most recently
from
August 17, 2026 13:31
2462d77 to
cfdc6de
Compare
BoldBlackBot
force-pushed
the
feat/repeatable-env-file
branch
from
August 18, 2026 21:30
cfdc6de to
8064b7c
Compare
BoldBlackBot
force-pushed
the
feat/repeatable-env-file
branch
from
August 30, 2026 21:31
8064b7c to
cdceb43
Compare
Previously -e/--env-file was a single-value option: passing it twice silently dropped the first file (minimist last-value-wins). This mirrors the existing --volumes pattern to normalize the value into an array, emitting one docker --env-file flag per input. Use case: composing env files across invocations (e.g. a base secrets file + a project-specific overrides file) without creating a merged file for every permutation. Backward compatible — single -e still works unchanged. Co-authored-by: Julio Capote <6135+capotej@users.noreply.github.com>
BoldBlackBot
force-pushed
the
feat/repeatable-env-file
branch
from
September 2, 2026 02:33
cdceb43 to
62d8d17
Compare
capotej
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-e/--env-filewas previously a single-value option. Passing it twice silently dropped the first file (minimist last-value-wins). This PR makes it repeatable, mirroring the existing--volumespattern.Motivation
Real use case: certain harness invocations need a mix of env files (e.g. a base secrets file + a project-specific overrides file). Without this, you'd have to create a merged env file for every permutation.
Changes
argv["env-file"]intostring[](same pattern as--volumes), so both single and repeated values work--env-file <path>flag per input file viaflatMapAgentOptions.envFilePath→envFilePaths: string[](onlyPiAdapterreads it, for the local-mode provider decision); may be repeated(matching-v, --volumes)HARNESS_CLOUD_MODE) now checksenvFilePaths.length > 0Backward compatibility
Single
-e file.envworks identically — the normalize step wraps it in an array.Test plan
pnpm build— clean compile (tsc --noEmit)pnpm lint:ts— biome cleanpnpm test:e2e— 117/117 pass, including 3 new tests:-epasses all env files as separate--env-fileflags--helpdocuments-emay be repeated