Fix package mappings and plain directory import shadowing#540
Open
l46983284-cpu wants to merge 1 commit into
Open
Fix package mappings and plain directory import shadowing#540l46983284-cpu wants to merge 1 commit into
l46983284-cpu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__init__.py) and module files should hide imports from requirements outputdocker,mysql-connector-python,streamlit-aggrid,pyro-ppl, andpyahocorasickmodelsandsrcmappings that can add unrelated packages for common local module/folder namespineconeas the current official package name instead of adding the deprecatedpinecone-clientmappingIssues
Fixes #187
Fixes #233
Fixes #438
Fixes #168
Fixes #177
Fixes #261
Fixes #281
Fixes #449
Related to #329 and #431.
Verification
python3 -m unittest tests.test_pipreqs.TestPipreqs.test_get_all_imports tests.test_pipreqs.TestPipreqs.test_get_all_imports_does_not_hide_imports_behind_plain_dirs tests.test_pipreqs.TestPipreqs.test_get_pkg_names tests.test_pipreqs.TestPipreqs.test_get_pkg_names_maps_current_package_aliasespython3 -m tox -e py311,flake8