Protect custom savepath from accidental overwrite#536
Open
StantonMatt wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--savepathfiles--print,--diff,--clean, and stdout output from being blocked by the file-generation guardFixes #336.
Verification
.venv/bin/python -m unittest tests.test_pipreqs.TestPipreqs.test_init_savepath tests.test_pipreqs.TestPipreqs.test_init_overwrite tests.test_pipreqs.TestPipreqs.test_init_savepath_does_not_overwrite_existing_file_without_force tests.test_pipreqs.TestPipreqs.test_init_savepath_force_overwrites_existing_file tests.test_pipreqs.TestPipreqs.test_init_savepath_existing_file_does_not_block_diff tests.test_pipreqs.TestPipreqs.test_init_savepath_existing_file_does_not_block_clean.venv/bin/python -m unittest discoveruv run --with flake8 flake8 pipreqs testsgit diff --checkreview-fix-loop clean