Repository navigation
Conversation
fhgffy
marked this pull request as ready for review
October 6, 2026 12:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkUpdate()only consumes the response body for a successful HTTP status. A non-2xx response returns an empty string without closing the response, leaving its connection or cached body open after the update check finishes.Wrap the response in
use, matching the existing HTTP cleanup pattern elsewhere in the Manager. The current logging, parsing and no-update fallback stay unchanged.Reproduction and checks:
APModuleViewModel.ktwith Kotlin 2.4.10 and Java 21 in an external JVM harness, using real OkHttp 5.5.0, a loopback HTTP server and a real disk cachegit diff --checkpassesThe harness uses boundary stubs for Android/Compose/lifecycle and app initialization, and JSON-Java in place of Android's JSON implementation. It is an external reproduction, not a committed Android test target. Full Gradle/Android build, lint, emulator/device and instrumentation checks have not been run. This change is limited to response cleanup in the Manager.