Skip to content

docs: require Closes #N in PR bodies so issues auto-close on merge - #142

Merged
Rinse12 merged 1 commit into
masterfrom
docs/agents-md-pr-auto-close
Sep 1, 2026
Merged

docs: require Closes #N in PR bodies so issues auto-close on merge#142
Rinse12 merged 1 commit into
masterfrom
docs/agents-md-pr-auto-close

Conversation

@Rinse12

@Rinse12 Rinse12 commented Sep 1, 2026

Copy link
Copy Markdown
Member

Issue #140 stayed open after PR #139 merged because nothing carried a closing keyword — the PR body only referenced the issue. AGENTS.md now requires Closes #N in the PR body (and keeps closing keywords out of commit messages), while manual gh issue close still requires asking first.

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidance for automatically closing issues through pull request descriptions.
    • Clarified that agents should request confirmation before manually closing an issue.

@Rinse12
Rinse12 merged commit b465974 into master Sep 1, 2026
1 check was pending
@Rinse12
Rinse12 deleted the docs/agents-md-pr-auto-close branch September 1, 2026 03:00
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: e5dcf66f-91d1-4b2a-8132-08e919f3161a

📥 Commits

Reviewing files that changed from the base of the PR and between c0bfdc8 and b465974.

📒 Files selected for processing (1)
  • AGENTS.md

📝 Walkthrough

Walkthrough

The change updates AGENTS.md with separate rules for automatic issue closure through pull requests and manual issue closure through gh issue close.

Changes

Issue Closure Guidance

Layer / File(s) Summary
Update issue closure rules
AGENTS.md
The guidance places Closes #N`` in the PR body, prohibits it in commit messages, and requires user approval before manual issue closure.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/agents-md-pr-auto-close

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant