feat(validation): add SQL structure security rules - #16
Open
abdul-kaioum wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds reusable validation rules for simple SQL identifiers and sort directions, with end-to-end coverage for malicious sort payloads, exact errors, nullable semantics, and first-failure behavior. It also restores PHP compatibility in the nested helper, documents the SQL security boundary, and adds a PHP 5.6 parse/rule-smoke CI gate.
Motivation & Context
Text sanitization does not make caller-controlled SQL structure safe. Consumers need explicit validation for single identifier segments and
asc/desc, while database-layer allowlisting and typed identifier handling remain mandatory.Type of Change
Security Boundaries
sql_identifiervalidates one unqualified identifier segment; it does not quote SQL.sort_directionvalidatesascordesc; it does not build anORDER BYclause.sanitize:textandsanitize:keyare not SQL-context controls.Verification
git diff --checkpassChecklist
Notes
The GitHub-hosted PHP 5.6 workflow has not yet run; local container parse/smoke verification passed. Existing Pest deprecation notices remain visible but do not fail the suite.