Skip to content

fix: Checkout commit from forked repo - #393

Open
mboutet wants to merge 2 commits into
biojppm:masterfrom
mboutet:patch-2
Open

mboutet wants to merge 2 commits into
biojppm:masterfrom
mboutet:patch-2

Conversation

@mboutet

@mboutet mboutet commented Nov 12, 2023

Copy link
Copy Markdown
Contributor

Possible fix for #392

include(FetchContent)
FetchContent_Declare(ryml
GIT_REPOSITORY https://github.com/biojppm/rapidyaml.git
GIT_REPOSITORY https://github.com/${PULL_REQUEST_HEAD_REPO:biojppm/rapidyaml}.git

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with Make's syntax, so feel free to edit. I want to use PULL_REQUEST_HEAD_REPO and fallback to biojppm/rapidyaml if PULL_REQUEST_HEAD_REPO is not set.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mboutet
mboutet marked this pull request as ready for review November 12, 2023 17:16
@codecov

codecov Bot commented Nov 12, 2023

Copy link
Copy Markdown

Codecov Report

Merging #393 (60aa4da) into master (2cf09b0) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          22       22           
  Lines        8155     8155           
=======================================
  Hits         7877     7877           
  Misses        278      278           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@biojppm
biojppm force-pushed the master branch 4 times, most recently from d128813 to 507400e Compare April 16, 2024 23:52
@biojppm
biojppm force-pushed the master branch 2 times, most recently from fbee0da to e4aa0b3 Compare August 24, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants