Repository navigation
State the seam gap instead of dismissing it - #1
Merged
Merged
Conversation
"Nothing there to test" read as a dismissal of integration testing. The gap was real and worth naming: neither repository covered the two deployed together. Matches the wording in the gist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The injector write-up said the seam went untested "because there is nothing there to test". That reads as a dismissal of integration testing, when the gap was real and worth naming: neither repository covered the two deployed together.
Same wording as the gist that links here, so the two agree.
Prose only. No behaviour change.