Add Save suppressions checkbox to auto-fix workflow#40
Conversation
| try { | ||
| execFileSync(commitHelperPath, [ | ||
| "-m", | ||
| `chore: add ${newSuppressions.length} suppression(s) from developer feedback`, |
There was a problem hiding this comment.
[Bugs & Correctness] suggestion
In runSaveSuppressions(), resolveThread() is called for all rejected findings unconditionally — even when generateSuppressions() returns an empty array (no suppressions generated). If the LLM returns empty output, thumbs-downed threads are marked resolved and won't be re-processed on subsequent runs, silently losing the developer's feedback. The original code had the same structure, but now that this function is also called standalone via the checkbox, the impact is more visible. Consider only resolving threads when at least one suppression was actually committed.
|
🦸 Review Hero Summary Below consensus threshold (2 unique issues not confirmed by majority)
Local fix prompt (copy to your coding agent)Fix these issues identified on the pull request. One commit per issue fixed.
|
🦸 Review Hero
Summary
Save suppressionscheckbox (<!-- #save-suppressions -->) to the PR template and auto-fix workflow so the suppressions-from-feedback step can be triggered on its own — useful when there's nothing to auto-fix but 👎 reactions need to be captured.main()into a dedicatedrunSaveSuppressions()function inscripts/auto-fix.mjs. The function is called from the new "nothing to fix" branch (when the checkbox is ticked alone) and unconditionally at the end of every auto-fix run, preserving prior automatic behaviour.Test plan
Save suppressionson a PR with 👎 reactions — verify the workflow runs, posts theSaved N suppression(s)comment, commits to.github/review-hero/suppressions.yml, and unchecks the boxSave suppressionson a PR with no 👎 reactions — verify the workflow runs and postsNo new suppressions to save.Auto-fix review suggestions(withoutSave suppressions) on a PR that has both unresolved comments and 👎 reactions — verify auto-fix still saves suppressions automatically at the end of the runSave suppressionsalongsideAuto-fix review suggestions— verify both checkboxes are unchecked after completion🤖 Generated with Claude Code