Repository navigation
revert: delete weavy modules and weavy-phon - #8
Merged
Merged
Conversation
The durable-module / admission / weavy-phon stack is half-baked and is what pulled phon-schema (and therefore PHON) into the VM crate. Cut it. weavy is the lowered-program substrate again: no SchemaId, no .weavy container, no FeatureId policy theater. Snark's weavy-phon facade will fail until it drops that path.
Blacksmith 2-core runners, same five jobs as taxon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Weavy modules are half-baked and must die. That stack is the only reason
weavydepends onphon-schema(and therefore PHON).Cut
weavy/src/module.rs(WeavyModule, admission,Schema/SchemaIdconstant ranges)weavy-phon(PHON-backed.weavycodec)phon-schema/phon-storage/ facet git pins from the weavy workspaceweavyis the lowered-program substrate again: IR, mem, interpreter, optional copypatch JIT. No SchemaId. No durable container.Breakage
Snark's
weavy-phon/weavy::modulefacade will fail until it drops that path. That is intended.Gate-0 / bytecode-architecture docs still mention weavy-phon. Implementation is gone; those docs are leftover speculation, not a surviving API.
Verify
cargo check --workspace --all-targets --lockedcargo nextest run --workspace --locked— 234 passedcargo clippy --workspace --all-targets --locked -- -D warnings