Render bold and emphasis as plain bold/italic#86
Merged
Conversation
adoc-bold-face and adoc-emphasis-face inherited adoc-gen-face, tinting bold and emphasized text with the function-name color (and, since that face is itself bold, emphasis came out bold-italic). asciidoc-mode and the wider ecosystem (markdown-mode, org-mode) render these plain. Drop the tint so switching between adoc-mode and asciidoc-mode is less jarring; titles and other adoc-gen-face users are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adoc-bold-faceandadoc-emphasis-faceinheritedadoc-gen-face, which tints the text with the function-name color - and since that face is itself bold,_emphasis_came out bold-italic. asciidoc-mode and the wider ecosystem (markdown-mode, org-mode) render these plain.Drop the tint so switching between adoc-mode and asciidoc-mode isn't jarring. Titles and other
adoc-gen-faceusers are unaffected. Anyone who preferred the tint can customize the two faces back.