fix: declare Base source dependencies in workspace manifest - #12
Merged
codeforester merged 1 commit intoSep 9, 2026
Conversation
codeforester
deleted the
bug/11-20260909-include-base-s-source-dependencies-in-the-canonical-workspac
branch
September 9, 2026 00:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing required
base-bash-libscheckout to the canonical workspace manifest.base-cliwas already present and remains required. The first-partybase-cli-demoandbase-bash-libs-demorepositories remain listed, but are now optional so a normal workspace clone does not require demo checkouts.Issue
Closes #11
Validation
./tests/validate.shruby -e 'require "yaml"; data = YAML.load_file("workspace.yaml"); abort "invalid manifest" unless data.dig("repos").is_a?(Array); puts "workspace.yaml parsed: #{data["repos"].length} repositories"'\n-env -u BASE_HOME BASE_CACHE_DIR=/private/tmp/base-workspace-cache /Users/rameshhp/work/base/bin/basectl workspace clone --workspace <empty-temp-workspace> --manifest workspace.yaml --dry-run\n-git diff --check\n\nThe dry run plannedbase,base-bash-libs, andbase-cli; it skipped missing optional demos with the documented--include-optionalguidance.\n\n## Notes\n\nThis is a workspace metadata and validation change only. It does not change Base runtime dependency resolution or either demo repository.