feat: make max-outbound-peers configurable via MAX_OUTBOUND_PEERS env var#1081
Open
erhnysr wants to merge 1 commit into
Open
feat: make max-outbound-peers configurable via MAX_OUTBOUND_PEERS env var#1081erhnysr wants to merge 1 commit into
erhnysr wants to merge 1 commit into
Conversation
… var The --max-outbound-peers flag in reth-entrypoint was hardcoded to 100 with no way to override it without modifying the entrypoint directly. Operators experiencing 'Send Queue full' gossipsub warnings (see base#1063) need to increase this value to improve peer connectivity, but had no documented way to do so. This change: - Adds MAX_OUTBOUND_PEERS variable to reth-entrypoint (default: 100, preserving existing behaviour) - Documents the variable in .env.mainnet and .env.sepolia with a reference to the related issue Fixes base#1063 (partially — the configurable peer limit addresses the root cause for operators with port access issues)
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Reth
--max-outbound-peersflag configurable via aMAX_OUTBOUND_PEERSenvironment variable instead of being hardcoded to100.Problem
Operators experiencing persistent
Send Queue fullgossipsub warnings (#1063) need to increase the outbound peer limit to resolve the issue. However,--max-outbound-peers=100was hardcoded inreth-entrypointwith no way to override it without modifying the entrypoint script directly.Changes
reth/reth-entrypoint: Replace hardcoded--max-outbound-peers=100with$MAX_OUTBOUND_PEERS(default:100, preserving existing behaviour).env.mainnetand.env.sepolia: DocumentMAX_OUTBOUND_PEERSwith usage guidance and reference to v0.15.5 Persistent "Send Queue full" in gossipsub despite low peer count and idle bandwidth #1063Behaviour
No change for existing operators — default remains
100. Operators who need more peers can now set:Closes #1063 (partially)