Repository navigation
Apply QA context to automatic Google Analytics events - #153
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Google Analytics engagement events lacked the QA/internal markers attached to explicit pageviews. Share the existing allowlisted session context with destination configuration so automatic events inherit debug_mode, analytics_test, is_internal and traffic_type. Ordinary traffic still omits debug_mode entirely; consent, DNT, sanitized URLs and identity ownership remain unchanged.
All 12 local release gates pass with 17 analytics tests, zero warnings and audit 0. A real Google SDK comparison reproduced unmarked automatic engagement on main and verified the fix for normal, QA, internal, decline and DNT modes. All collector requests were intercepted; this verifies native serialization without claiming Google storage or filter enforcement. No filter settings changed.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.