Skip to content

Update core-js - #264

Open
zloirock wants to merge 1 commit into
babel:mainfrom
zloirock:update-core-js
Open

zloirock wants to merge 1 commit into
babel:mainfrom
zloirock:update-core-js

Conversation

@zloirock

@zloirock zloirock commented Aug 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@zloirock

zloirock commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

The linting issue is not related to those changes.

@zloirock

Copy link
Copy Markdown
Member Author

@nicolo-ribaudo

@JLHwung

JLHwung commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

@zloirock The lint error is related. Babel only accepts the string-type targets but somehow core-js-compat uses number for oculus.

@zloirock

zloirock commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

@JLHwung I'll convert it to strings in the next release, after a couple of weeks. But anyway, it's not related to this PR since core-js-compat is specified on the babel side with ^ in dependencies, and this PR does not touch this logic.

@JLHwung

JLHwung commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

@JLHwung I'll convert it to strings in the next release, after a couple of weeks. But anyway, it's not related to this PR since core-js-compat is specified on the babel side with ^ in dependencies, and this PR does not touch this logic.

Didn't you bumped @babel/preset-env/core-js-compat from 3.48 to 3.50?

@zloirock

zloirock commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

@JLHwung users already get core-js-compat@3.50 because of ^ even without this PR, and I don't see any issues because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants