test/ringbuf-read: bound strcpy of argv[1] into fname#1582
Merged
Conversation
main() copies argv[1] into the 80-byte fname[] stack buffer with an
unbounded strcpy. Passing a path longer than 79 bytes overflows the
buffer and clobbers the surrounding frame, e.g.
$ ./ringbuf-read $(python3 -c 'print("A"*256)')
triggers a stack-buffer-overflow under -fsanitize=address. Replace
the strcpy with snprintf() bounded by sizeof(fname).
Signed-off-by: rootvector2 <dxbnaveed.k@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack overflow in test/ringbuf-read.c main() — argv[1] is copied into the
80-byte fname[] with an unbounded strcpy. Running the test with a long
path argument trips a stack-buffer-overflow under ASan.
Replace the strcpy with snprintf() bounded by sizeof(fname). Full
context is in the commit message.