Skip to content

test(runner): publish sibling pids atomically in the cancellation case #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apackeer wants to merge 1 commit into from
Closed

test(runner): publish sibling pids atomically in the cancellation case #1400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/integration/t-e2e-isolated-runner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,9 +546,11 @@ test("capture failure",async()=>{
for (let i = 1; i <= 7; i++) {
files[`t0${i}-waiting.test.ts`] = `
import {test} from "bun:test";
import {writeFileSync} from "node:fs";
import {renameSync,writeFileSync} from "node:fs";
test("waits",async()=>{
writeFileSync(${JSON.stringify(join(witnesses, String(i)))},String(process.pid));
const witness=${JSON.stringify(join(witnesses, String(i)))};
writeFileSync(witness+".tmp",String(process.pid));
renameSync(witness+".tmp",witness);
await new Promise(()=>{});
},20000);
`;
Expand All @@ -572,7 +574,9 @@ ${needle}`));
expect(Date.now() - started).toBeLessThan(15_000);
expect(result.code, result.output).not.toBe(0);
expect(result.output).not.toContain("QUEUED_SENTINEL_RAN");
const records = readdirSync(witnesses);
// A sibling publishes its pid by rename, so a witness is never half
// written. One cancelled mid-write leaves only its `.tmp`, and no pid.
const records = readdirSync(witnesses).filter((name) => !name.endsWith(".tmp"));
expect(records.length).toBeGreaterThan(0);
for (const file of records) {
const pid = Number(readFileSync(join(witnesses, file), "utf8"));
Expand Down
Loading