fix(onboarding): render user-typed skill names with the harness skill prefix

[vnlebaoduy]

Rebased onto v2.10.0.

What is left of #1341

#1341 is closed by #1363, which corrected the three session skills' frontmatter descriptions and documented the {{INVOKE}} engine runtime summary --json fallback for harnesses that do not surface skills as slash commands. That did not touch core/templates/onboarding-harness.md, and the line an operator actually reads first is still wrong on main:

$ git show origin/main:core/templates/onboarding-harness.md | grep -o "{{INVOKE}}-[a-z<>-]*" | sort -u
{{INVOKE}}-<stage>  {{INVOKE}}-code-generation  {{INVOKE}}-domain-design  {{INVOKE}}-init
{{INVOKE}}-knowledge  {{INVOKE}}-outcomes-pack  {{INVOKE}}-replay  {{INVOKE}}-session-cost

{{INVOKE}} is a shell command — bun <harness-dir>/tools/aidlc.ts in the copy channel, aidlc in the native one. Glued to a skill suffix it renders bun .claude/tools/aidlc.ts-session-cost, which is not a command on any harness. It covers the three session skills, the document skill, the per-stage runners, and -init.

The token for this already existed, and 2.10.0 started using it

scripts/onboarding.ts declares {{SKILL_INVOKE}} and OnboardingFills.invoke ("The invoke command this harness uses, e.g. /aidlc or $aidlc"); renderOnboarding substitutes it and guards against a leftover marker. Every harness already declares its value.

#1262 landed in 2.10.0 and is the first use of that token — in this same file, for exactly this purpose: {{SKILL_INVOKE}} --guard-policy relaxed for what the person types, {{INVOKE}} engine config set guard-policy strict for what the engine runs. This change applies the same distinction to the eight remaining command names and leaves the five real shell invocations on {{INVOKE}}.

Before / after

Rendered through renderOnboarding with each harness's own fills:

harness	before	after
claude, copilot, cursor, kiro, kiro-ide, opencode	bun <dir>/tools/aidlc.ts-session-cost	/aidlc-session-cost
codex	bun <dir>/tools/aidlc.ts-session-cost	$aidlc-session-cost

Codex is why this uses the token rather than a literal /aidlc-…: it declares $aidlc, and hardcoding the slash form would be wrong there. A harness that needs a different prefix changes one line in its own onboarding.fills.ts.

Shipped-bytes consequence

Copilot's manifest sets onboarding: { dst: "AGENTS.md", projectRoot: true } with no harnessDst, so the harness skeleton is embedded in its root AGENTS.md and those bytes change. Its previously shipped hash moves into harness/copilot/manifest.ts so a copy-channel install still carrying it stays adoptable on refresh, and t243's inventory pins the new current hash — the handling #1131 needed.

The other five AGENTS.md harnesses project the skeleton to a separate file (steering/aidlc-onboarding.md, onboarding.md, rules/aidlc-onboarding.mdc), so their root bytes are unchanged and they need no entry. I checked that against the rebuilt projections rather than assuming the #1131 shape: the packager appended no new hash for those five.

Tests

t151 gains a pin with two halves. The class guard is expect(HARNESS).not.toMatch(/\{\{INVOKE\}\}-/) — {{INVOKE}} followed directly by a suffix is always this mistake, so a future line cannot reintroduce it. The behavioural half renders the skeleton under both a /aidlc and a $aidlc harness and asserts each skill name carries that prefix and that no aidlc.ts- survives.

Ablation: reverting the template to {{INVOKE}}- reddens it (7 pass / 1 fail). t243's legacy-signature inventory independently catches the copilot byte change.

Gates on 20008a5d: bun run check green, t151 8/8, t243 116/116.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

[apackeer]

Thanks for this. The diagnosis is right, and the fix renders the correct skill prefix on all seven harnesses in both the copy and native channels. The copilot legacy-hash handling matches what #1262 did.

I pushed one follow-up commit (aba29e7) for two more examples in the same lines that rendered commands the CLI rejects:

• {{INVOKE}} --stage <slug> --single rendered bun .claude/tools/aidlc.ts --stage ..., which fails with unknown command '--stage'. It's the skill flag, so it's now {{SKILL_INVOKE}} --stage <slug> --single, matching docs/guide/12-cli-commands.md.
• {{INVOKE}} knowledge <verb> rendered bun .claude/tools/aidlc.ts knowledge ..., which fails with unknown command 'knowledge'. Knowledge is an engine noun, so it's now {{INVOKE}} engine knowledge <verb>.

t151 now pins both for every harness and channel, and copilot's new AGENTS.md hash replaces the unshipped one in t243 (no extra legacy entry needed).

Approving. We'll take it from here and merge.