Conversation
core/templates/onboarding.md documented the intent record dir as <slug>-<id8>, but the engine writes the date-prefixed <YYMMDD>-<label> form (aidlc-lib.ts calls <slug>-<id8> the legacy fallback). The template rendered that stale shape into all seven onboarding files, contradicting stage-definition.md and the rest of the docs. Fix the single token and regenerate; bun scripts/package.ts --check stays green on all seven trees.
The onboarding drift fixed in the previous commit survived because t174 -- the docs legacy-ref allowlist gate that scans docs/**/*.md plus core/templates/*.md and each harness SKILL.md -- had no lane for the retired record-dir shape. Its four predicates covered aidlc-docs, bare --init, dotted rules dirs, and *-learnings.md filenames, so a template stating <slug>-<id8> as the current shape passed clean. Add a fifth lane, /<slug>-<id\d*>/, which also catches the <slug>-<id10> longer-prefix variants the pre-spike collision scheme used. Verified by reintroducing the exact issue awslabs#1009 line into core/templates/onboarding.md (the gate reds and names the file:line) and by injecting <slug>-<id10> into docs/guide/14-artifacts-reference.md (also caught). No allowlist entry was needed: the scanned set holds zero occurrences, so the pinned count stays at 15 of the ceiling 15. The fixture's own _comment described lane (1) using <slug>-<id8> as the current shape -- the gate that polices retired tokens carried the retired token. Rewritten to <YYMMDD>-<label>, with lane (5) documented. Test-tier only: no engine or dist change, so no version bump per the changelog policy.
fsatsuki
requested review from
a team,
Kalindi-Dev,
apackeer,
harmjeff,
leandrodamascena,
raj-jain-dev,
scottschreckengaust and
spraja08
September 7, 2026 08:59
github-actions
Bot
added
the
documentation
fsatsuki
changed the title
4 of 5 tasks
Contributor
|
Thank you, @fsatsuki, for picking up #1009 first — the one-token diagnosis here is exactly right, and it matches what has now been verified against current This branch has drifted, though: it commits regenerated Closing this as superseded by #1131 so #1009 has a single path to closure. If you spot anything the merged change missed, please open a follow-up issue and tag me — happy to look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the stale record-dir shape in the onboarding template reported in #1009.
core/templates/onboarding.md:47(under## Conventions) documented the active intent's record dir asaidlc/spaces/<active-space>/intents/<slug>-<id8>/, but the engine actually writes the date-prefixed<YYMMDD>-<label>form (e.g.260903-novos-harness).core/tools/aidlc-lib.tsitself calls<slug>-<id8>the legacy fallback (recordDirMatches()), and every other doc —stage-definition.md,docs/reference/*,docs/guide/*— already states<YYMMDD>-<label>. This template was the only outlier, and because it renders into all seven onboarding files, every session was told the wrong shape on startup, contradicting the instruction files it later loads.Change
One token in
core/templates/onboarding.md:bun scripts/package.tsregenerates the seven onboarding files, which carry the same one-line change:dist/claude/.claude/CLAUDE.mddist/codex/AGENTS.mddist/copilot/AGENTS.mddist/cursor/AGENTS.mddist/kiro-ide/AGENTS.mddist/kiro/AGENTS.mddist/opencode/AGENTS.mdVerification
bun scripts/package.ts --check→ all seven harness trees reportOK/ in sync.git diff --stat: 8 files changed, 8 insertions(+), 8 deletions(-) — the template token plus the seven regenerated files, nothing else.Scope notes
<slug>-<id8>occurrences in authored sources are all inside TypeScript comments (several explicitly marking it the legacy form); the issue scopes those out, so this PR does not touch them.<slug>-<id8>predicate to catch future regressions. That is deliberately left out of this minimal fix and can follow as a separate change.Closes #1009
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.