Skip to content

feat(ci): enable AI review commands and activity events - #697

Open
zhongkechen wants to merge 3 commits into
mainfrom
fix/ai-review-command-triggers
Open

feat(ci): enable AI review commands and activity events#697
zhongkechen wants to merge 3 commits into
mainfrom
fix/ai-review-command-triggers

Conversation

@zhongkechen

Copy link
Copy Markdown
Contributor

Summary

  • mirror the pinned reusable AI review workflow's supported event triggers
  • enable authorized /ai review commands through pull request issue comments
  • record activity for submitted, edited, or dismissed reviews and created, edited, or deleted review comments
  • add regression coverage for the caller event contract

Follow-up to #695.

Validation

  • parsed the modified workflow with PyYAML
  • ran both AI review workflow regression assertions directly
  • ran git diff --check
  • ran .github/scripts/lintcommit.py

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime August 31, 2026 18:53 — with GitHub Actions Inactive
@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime August 31, 2026 19:07 — with GitHub Actions Failure
@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime August 31, 2026 19:07 — with GitHub Actions Failure
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime August 31, 2026 19:31 — with GitHub Actions Inactive
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime August 31, 2026 19:31 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime September 1, 2026 23:10 — with GitHub Actions Inactive
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime September 1, 2026 23:10 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Claude AI review

This PR mirrors the pinned reusable AI-review workflow's supported trigger events (pull_request_review, pull_request_review_comment, issue_comment) onto the caller workflow .github/workflows/ai-pr-review.yml, and adds a matching regression test in .github/scripts/tests/test_ai_pr_review_workflow.py.

Checks performed:

  • The added on: block is valid YAML with correct, documented types values for each event (pull_request_review: submitted/edited/dismissed; pull_request_review_comment: created/edited/deleted; issue_comment: created), consistent with the existing 2-space indentation style.
  • The new test's string assertion matches the workflow text exactly and follows the same containment-check pattern as the pre-existing permissions test.
  • Job-level permissions (contents: write, id-token: write, pull-requests: write) and secrets: inherit are unchanged; this PR only broadens which events can invoke the already-privileged job, per the PR description's stated intent to catch the caller up with event types the external reusable workflow was already built to handle.
  • No SDK runtime, checkpoint/replay, serialization, or public API code is touched — this is CI configuration only, and the change is minimal and internally consistent.

No correctness defects were found in the diff. Residual risk worth noting (not a confirmed defect, since it depends on code outside this diff): the actual authorization gating for /ai review comments, and whether the pinned aws/aws-durable-execution-ci reusable workflow avoids re-triggering on its own bot-authored reviews/comments or safely no-ops for issue_comment events on non-PR issues, all live in that external, SHA-pinned reusable workflow and cannot be inspected as part of this review. Confirming this with a live test PR after merge is advisable, but nothing in the changed files here indicates a bug.

Reviewed commit 7db93ae7cce39e0b1777fbacc919fe8b6b8fee5f. Workflow run

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. Residual risk: the regression test checks workflow text but does not exercise actual GitHub event dispatch or reusable-workflow behavior.

Reviewed commit 7db93ae7cce39e0b1777fbacc919fe8b6b8fee5f. Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant