Docs/migration 1x to 2x - #655
Conversation
31f5f5e to
162361b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
162361b to
e4ae074
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e4ae074 to
2681198
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
185e012 to
be09914
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
be09914 to
6c1c23f
Compare
This comment has been minimized.
This comment has been minimized.
Claude AI reviewDocumentation-only PR: a new I verified the guide's technical claims against the source rather than reviewing runtime behavior, since inaccurate migration docs would misdirect users:
No inaccurate statements or broken examples found. No actionable findings. Residual test risk: the guide's code snippets and Reviewed commit |
6c1c23f to
0edb4a6
Compare
| **default `map` / `parallel` completion** (which stops after the first failed | ||
| item unless you opt back into process-all). |
There was a problem hiding this comment.
Codex AI review · Finding arf_v1_5ulbaadkrlrjgwsvr6bgmz2tja
P1 — Clarify that fail-fast does not cancel in-flight branches. The executor stops scheduling pending branches after observing a failure, but already-started branches continue; with the default unlimited concurrency, every branch may be submitted before that failure is observed. The current wording can lead users to assume side-effecting branches will not run. Document the in-flight behavior and recommend max_concurrency when users need to bound it.
| **default `map` / `parallel` completion** (which stops after the first failed | |
| item unless you opt back into process-all). | |
| **default `map` / `parallel` completion** (which completes after the first | |
| observed failure and stops scheduling pending items; already-started items are | |
| not cancelled, so with unlimited concurrency all items may already be running). |
Codex AI reviewFound one high-impact documentation issue in the map/parallel migration guidance. No additional defects were confirmed. Reviewed commit |
Issue #, if available: N/A
Description of changes:
Migration guide for python v2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.