Repository navigation
fix(sdk): reject competing durable OTel views - #956
Merged
Merged
Conversation
zhongkechen
requested a deployment
to
ai-pr-review-runtime
October 2, 2026 20:42 — with
GitHub Actions
Waiting
This was referenced Oct 2, 2026
zhongkechen
added a commit
that referenced
this pull request
Oct 2, 2026
The JS caller grants `contents: read`, but the pinned reusable AI-review workflow requests `contents: write` for activity/publication jobs. GitHub rejects the workflow before review generation; [this run](https://github.com/aws/aws-durable-execution-sdk-js/actions/runs/37062142944) reports that the nested job is requesting write while the caller allows only read. Grant `contents: write` to the reusable-workflow call, matching its declared requirements and the Java/Python callers. The review generation job retains its own narrower contents grant. Validation: parsed the YAML and compared the before/after structures; the only change is this permission value. Checked the pinned reusable workflow and exact GitHub startup diagnostic; `git diff --check` passed. This configuration-only change does not alter SDK code. This must reach the trusted base/default branch before the blocked automatic reviews for #953, #954, #955 and #956 can start. No successful Actions execution is claimed from the PR-head change alone.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 3, 2026 01:46 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 3, 2026 03:18 — with
GitHub Actions
Error
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 3, 2026 03:37 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 6, 2026 19:20 — with
GitHub Actions
Error
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 6, 2026 22:23 — with
GitHub Actions
Failure
nvasiu
reviewed
Oct 6, 2026
nvasiu
reviewed
Oct 6, 2026
added 6 commits
October 6, 2026 23:19
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 7, 2026 17:24 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
nvasiu
reviewed
Oct 7, 2026
Codex AI reviewNo actionable findings. Residual test risk: installed-package compatibility coverage exercises CommonJS consumers only; the equivalent ESM provider/layer path remains untested. Reviewed commit |
nvasiu
approved these changes
Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject competing bundled OTel views across explicit and environment configuration. The loader validates all declared provider types before calling any environment-selected factory, so a conflicting dynamic pair cannot install sampler or ID-generator wrappers on the global tracer. Diagnostics identify the concrete plugin classes, including subclasses.
The bundled views declare inherited static metadata through a namespaced symbol shared across package copies. The base hook interface and ordinary plugin properties remain unchanged. Existing instance metadata remains supported, and returned instances are checked too so a v1 provider that declares a broader base class cannot bypass exclusivity. Explicit instances have already been constructed by the application before registration; validation cannot undo that construction.
Compatibility stays additive: provider API version 1 and handler-scoped factory calls remain unchanged. OTel's core peer stays optional (
>=2.4.0 <3.0.0), including separate OTel-only layers beside a released core. The new exclusivity guarantee requires the coordinated core 2.7 / OTel 1.2 pair. The per-invocation factory migration remains separate in #924.Validation:
git diff --checkpass.The branch retains the shared bounded deployment/read-retry and scheduler-sensitive example fixture repairs from #959. Installed-consumer setup rebuilds candidate packages before packing to avoid stale outputs. Cloud checks run through PR CI; no packages were published.
Fixes #943.