Repository navigation
Set private=true in package.json to prevent accidental publishes to n… - #3
Merged
Merged
Conversation
Member
|
LGTM! |
bchampp
approved these changes
Sep 3, 2025
ParidelPooya
added a commit
that referenced
this pull request
Aug 2, 2026
Review items 3, 4, 5, plus two from the closing list. First, a note on approach. All three dag items are real — reproduced with `group` as the control, which gets both the deps shim and the onError try/catch and is correct. But none can be FIXED without deciding runtime API that does not exist yet: a map iteratee is `(ctx, item, index)` and a parallel branch is `(ctx)`, signatures inherited from the SDK's existing map/parallel, so there is nowhere to bind deps without inventing a parameter. Guessing would replace a silently wrong answer with a differently wrong one that looks authoritative. So these now REFUSE at codegen time, consistent with the dag gate. Nobody can generate code that runs and quietly does the wrong thing, and whoever lands the runtime has to make the call explicitly and delete the guards. #3 map iteratee / parallel branch referencing an upstream result: the reviewer's reading is exactly right. `return Up;` compiled and handed back the TaskHandle. The shim is injected only into map's ITEMS closure, and parallel gets none at all. Now refused, with a test asserting group still binds `const Up = deps["Up"]` so the guard cannot be mistaken for a blanket ban. #4 Confirmed all four arms, dagContainer included — only dagClosureBody emits the try/catch and these bypass it, so a dag workflow failed where the linear equivalent recovers. dagContainer honouring runIf but not onError is what makes it look accidental. Not uniformly fixable: a wait has no closure to wrap, and a dagContainer's callback only REGISTERS child tasks, so a try/catch there would catch registration rather than execution errors and give false confidence. All four refuse. #5 Confirmed. `dag.wait("W", [Up], { seconds: Up.s })` evaluates in the surrounding scope where Up is the handle, so the duration was undefined; the linear path works because there the name holds the value. No deps closure exists to inject into, so refused. From the closing list: - process.abort()/process.exit() are now neutered in the dry-run worker. Availability only, as noted, but abort takes down the whole extension host and it was cheap. Verified the host survives both. - npm.cmd on Windows (awsSdkReflect.ts): execFile cannot run the shell script shim, so this was ENOENT on Windows. 10 new tests. cdk 267, insight-vscode 413, visual-workflow-model 61, webview-ui 91.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pm registry
Issue #, if available:
Description of changes: Set
"private": truein package.json to prevent accidental publishes to npm registryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.