Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Run CLI example commands to validate parameter values and fix existing violations
The example command check only parses commands, so values were never checked: invalid JSON, bad shorthand, unknown nested members, values shorter than the model allows, or text passed to blob parameters all passed.
test_example_commands_runtotests/functional/docs/test_examples.py: each API operation and waiter command in an example runs through the CLI driver and stops atbefore-call, after the CLI has parsed the arguments and botocore has validated the parameters, so nothing is sent to AWSContents ofblocks are written to a temporary directory and the command'sfile://andfileb://references point at them; each example uses its own filess3 cpandemr create-cluster, and Windows examples, still go through the parse-only check onlyCommandValidatorinto_command_args, shared by both checks\continuations inside quoted JSON, which bash also passes to the CLIWindowId, kendra index IDsfileb://or--cli-binary-format raw-in-base64-out--cli-input-jsonfiles, unknown or missing members, wrong types, bad shorthand and--queryliteralsTesting
pytest tests/functional/docs/test_examples.py -n auto=== 70161 passed in 53.60s =====By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.