Repository navigation
Conversation
DmitriyMusatkin
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix:
tsh aws s3 cpgives GetObject operation: Forbidden - potentially due to CRT transfer client change gravitational/teleport#69876The CRT request serializer added "Content-Length: 0" to any request botocore left without a Content-Length and a body. Botocore already sets Content-Length on every non-GET/HEAD/OPTIONS request, so this only ever touched GetObject. aws-c-s3 treats a missing Content-Length as zero for GET_OBJECT and DEFAULT meta requests, and copies the initial headers onto every part GET and its HEAD, so the header only added a signed "content-length" to each of those requests.
Not immediately clear why this was originally added, but there weren't any observed regressions when testing against live S3 after removing. CRT team also confirmed CRT shouldn't need it.
History: