Repository navigation
Conversation
luigi617
marked this pull request as ready for review
October 29, 2026 15:44
luigi617
force-pushed
the
remove-optin-standard-retry
branch
from
October 29, 2026 19:26
bc15e19 to
5cf85f5
Compare
luigi617
force-pushed
the
remove-optin-standard-retry
branch
from
October 29, 2026 19:33
5cf85f5 to
ac4c82a
Compare
aemous
self-requested a review
November 2, 2026 17:18
aemous
reviewed
Nov 2, 2026
aemous
left a comment
aemous
left a comment
Contributor
There was a problem hiding this comment.
Looks like upstream has some changes to test_client.py. Is there a reason we excluded those updates?
Code looks good overall. Have some questions.
aemous
reviewed
Nov 2, 2026
aemous
left a comment
aemous
left a comment
Contributor
There was a problem hiding this comment.
Did you do any manual testing apart from the new botocore test changes ?
Would be nice to have some end-to-end verification it works against the AWS CLI. For example, 1 new blackbox test that mocks service retry-able errors (maybe status 429). Can verify the number of attempts made, and maybe verify 4 are made for dynamodb, 3 for something else like s3.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Ports from boto/botocore#3815
standardandadaptiveretry modes now treat HTTP 429 responses as throttling errors and retry them when the error code does not match a modeled error for the operationamz-sdk-requestheader on the initial attemptDo not merge before 11/10.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.