Skip to content

Update configure set to validate configuration keys and values#10163

Open
aemous wants to merge 5 commits intoaws:developfrom
aemous:configure-ini-sanitzation
Open

Update configure set to validate configuration keys and values#10163
aemous wants to merge 5 commits intoaws:developfrom
aemous:configure-ini-sanitzation

Conversation

@aemous
Copy link
Contributor

@aemous aemous commented Mar 25, 2026

Description of changes:

  • Update configure set so that it returns an error if a newline or carriage return character is present in section/profile names, configuration keys, or values.
  • Added tests to verify the error is returned and new expected behavior.

Description of tests:

  • Passed all CI
  • TODO: Successfully ran build workflow.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested a review from a team March 25, 2026 18:04
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.41%. Comparing base (c4681b5) to head (f55a88c).
⚠️ Report is 219 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10163      +/-   ##
===========================================
+ Coverage    93.39%   93.41%   +0.02%     
===========================================
  Files          210      210              
  Lines        17052    17203     +151     
===========================================
+ Hits         15925    16071     +146     
- Misses        1127     1132       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants