Repository navigation
fix(schema): qualify wildcard cache keys by definition - #3421
Merged
Merged
Conversation
github-actions
Bot
added
the
area/tooling
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
josephschorr
force-pushed
the
fix/3418-wildcard-cache
branch
from
October 20, 2026 20:30
e550baf to
e6dbe8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wildcard-check cache is shared across definitions but was keyed only by relation name. A negative result for
ty1#rel0could hide the wildcard inty3#rel0, causing the same schema to be accepted or rejected depending on validation order. A cached positive result could also incorrectly affect an unrelated definition.Key cached results by the full
definition#relationreference. Add deterministic regression tests covering both cache orders and the reported schema after validating an unrelated definition.Fixes #3418
Validation:
go run mage.go test:unit: 107 packages passed.pkg/cmd/TestDefaultConfigfailed because port 50051 was already occupied by Docker; the same failure was reproduced on unchanged main.