propose: Add visual feedback when the intent input is cleared with Esc…#2
Open
atomeam wants to merge 1 commit into
Open
propose: Add visual feedback when the intent input is cleared with Esc…#2atomeam wants to merge 1 commit into
atomeam wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe Escape key handler for the global intent input field now displays a temporary "Intent cleared" info banner when pressed, providing visual user feedback alongside the existing clear-and-blur behavior. ChangesIntent Input User Feedback
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@mini/index.html`:
- Line 483: The UI now calls showBanner('info', ...) when Escape clears the
intent, but there's no CSS rules for a .banner.info state; add a dedicated style
for .banner.info (similar to existing
.banner.success/.banner.error/.banner.warning) to define background-color,
text-color, and any icon or border styles so the info banner is visually
distinct; update the stylesheet where .banner classes live and ensure the
selector .banner.info is applied when showBanner('info', ...) is invoked.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| intent.addEventListener('keydown', function(e){ | ||
| if (e.key === 'Enter') { e.preventDefault(); press(); } | ||
| else if (e.key === 'Escape') { intent.value = ''; intent.blur(); } | ||
| else if (e.key === 'Escape') { intent.value = ''; intent.blur(); showBanner('info', 'Intent cleared', 1000); } |
There was a problem hiding this comment.
Add a dedicated style for the new info banner state.
showBanner('info', ...) introduces a new banner kind, but there is no .banner.info style, so the feedback can be visually weak/inconsistent.
🎨 Suggested fix
.banner.error { background: `#7f1d1d`; color: `#fecaca`; border-bottom: 2px solid `#ef4444`; }
.banner.warn { background: `#78350f`; color: `#fed7aa`; border-bottom: 2px solid `#f59e0b`; }
.banner.success { background: `#14532d`; color: `#bbf7d0`; border-bottom: 2px solid `#22c55e`; }
+ .banner.info { background: `#1e3a8a`; color: `#dbeafe`; border-bottom: 2px solid `#60a5fa`; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@mini/index.html` at line 483, The UI now calls showBanner('info', ...) when
Escape clears the intent, but there's no CSS rules for a .banner.info state; add
a dedicated style for .banner.info (similar to existing
.banner.success/.banner.error/.banner.warning) to define background-color,
text-color, and any icon or border styles so the info banner is visually
distinct; update the stylesheet where .banner classes live and ensure the
selector .banner.info is applied when showBanner('info', ...) is invoked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by HomeBase using Mistral.
Summary: Add visual feedback when the intent input is cleared with Escape key
Patches: 1
Review the diff. Merge to deploy.
Notes seen by the model:
(none yet)
Summary by CodeRabbit