Fix doubled comma in CRTF output when range/corr is the only metadata - #700
Merged
Merged
Conversation
preller
marked this pull request as ready for review
August 23, 2026 16:54
keflavich
approved these changes
Aug 23, 2026
keflavich
left a comment
keflavich
left a comment
Contributor
There was a problem hiding this comment.
Good catch, assuming this passes CI, lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the CRTF writer emitting a doubled comma (
, ,) whenrangeorcorris the only metadata of a region, which makes the output unparseable by CASA. Relevant when CRTF files are generated programmatically for machine-readable pipelines. The metadata items are now collected in a list and joined once, so an empty separator cannot appear; this also removes the existing special case that guarded thecoord=key against the same problem. A regression test is included. Fixes #322