Repository navigation
Add resumable image batch generation - #114
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an image-only batch mode to
/generate: select up to 100 PNG/JPEG/WebP images (5 MiB each), review the list, and create one independent generation per image. Progress counts server-confirmed admissions, with a private result link for every accepted image.The batch keeps original files and per-image UUIDs in IndexedDB. It sends one POST at a time up to the existing server admission limits; it does not wait for earlier character reviews. Queue-full responses back off with the same UUID, while uncertain outcomes pause the batch. Closing the page preserves the remaining work for explicit resume.
Safety and recovery:
No public HTTP contract, worker, YDB schema, quota, or budget changes.
Validation:
No production deployment or paid generation runs were performed.


Confidence Score: 5/5 
The PR appears safe to merge; all three previous findings are addressed and no new actionable issue was found.Summary
Adds a resumable, image-only batch mode to
/generate.This review inspected the code and tests; it did not run the test suite.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Select images] --> B[Save files and request IDs] B --> C[Explicit start or resume] C --> D[Acquire browser lock and check saved batch] D --> E[Send one image] E --> F{Server response} F -->|Accepted| G[Save receipt and remove input together] G --> H[Save history] H --> E F -->|Queue full| I[Wait and retry same request ID] I --> E F -->|Known rejection| J[Pause with image ready] F -->|Uncertain| K[Pause and keep original request]Reviews (2) · Last reviewed commit: "fix: preserve batch retries and release ..." · Reviewed by Greptile