fix: clean up otel tracing and add workspace ID to trace resource#256
Merged
philipph-askui merged 1 commit intomainfrom Apr 2, 2026
Merged
fix: clean up otel tracing and add workspace ID to trace resource#256philipph-askui merged 1 commit intomainfrom
philipph-askui merged 1 commit intomainfrom
Conversation
Contributor
philipph-askui
commented
Apr 1, 2026
philipph-askui
commented
- Remove unused SQLAlchemyInstrumentor and its dependency
- Replace cluster_name with workspace_id (read from ASKUI_WORKSPACE_ID env var) in OTLP resource attributes
- Extract _get_next_message in Conversation for finer-grained trace spans
mlikasam-askui
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.