Conversation
…d-parity # Conflicts: # scripts/verify-android-ui.sh
Pull request footprint
User-delivered artifact sizes
|
Owner
Author
|
Contact sheets from final authorized CI run Android light, partialThe toolbar Search action expanded and focused the native field. The flow then stopped because Maestro could not resolve the visible placeholder. Android dark, partialThe flow reached the episode screen, but the Close control did not return to show detail. iOS light discoveryThe discovery shard completed. The detail shard failed during simulator preparation, so this is not a complete light-mode aggregate. iOS dark, partialThe flow reached the episode screen and reproduced the Close navigation failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




+973 / -209, net +764
Product-Growth: Product code grows by 79 lines to provide Android modal, menu, safe-area, marker, and episode navigation behavior while removing five product comment lines.
Binary-Size: The Firebase tester APK is unchanged. The Play download estimate is +0.7 kB; the iOS and Android JavaScript bundles are +0.6 kB and +1.4 kB.
Final CI run:
35478285903. Wall time was 14 minutes 55 seconds, below the 15 minute target. The run is red: Android light expanded and focused Search but could not resolve the visible native placeholder, Android dark and iOS dark stayed on the episode sheet after the Close control was tapped, and iOS light detail lost its simulator transport during preparation. The corrected required aggregate failed because a required shard failed. All four authorized CI cycles were used, so no additional push or rerun was made.Final job timings
Android defects found
MenuViewhost dropped dynamic React Native children in the virtualized grid; Android now renders the child outside the host and opens an invisible native menu anchor imperatively on long press.router.dismiss()does not return to show detail on Android or iOS in the final run.Other findings
response-timingnow uses the same one-point, accessible, non-collapsableMarkerprimitive and root placement rule asapp-idle-timing. Run35474602384completed the marker copy and exposedResponse timing: mark 28.6 ms, undo 43.8 msin the accessibility evidence.native-e2echeck now runs withalways()and fails when its required detail shard fails.35478285903did not exercise iOS detail because simulator preparation failed with a local transport connection reset before the flow started.Verification
pnpm checkpasses with 830 repository tests and 488 native Jest tests.2d54b39, clean, and pushed at456b3d4.