Rewrite Cue as a native Expo app over a shared core

.dependency-cruiser.cjs

@@ -1,16 +1,22 @@
 // dependency-cruiser resolves every `to.path` against the *resolved* module
 // path, not the import specifier. Under pnpm that means npm packages surface as
 // `node_modules/.pnpm/<pkg>@<ver>/node_modules/<pkg>/...`, so npm bans must match
-// the `(^|/)node_modules/<pkg>/` tail: a bare `^react` / `^@capacitor/` anchor
-// never fires. Node built-ins carry dependencyType "core", matched separately.
+// the `(^|/)node_modules/<pkg>/` tail. Node built-ins carry dependencyType
+// "core", matched separately.
+// An UNINSTALLED package is the one exception: nothing resolves it, so its
+// module path is the specifier itself, which is why the expo and react-native
+// bans below carry both spellings.
 const RE_REACT = "(^|/)node_modules/react/";
 const RE_REACT_DOM = "(^|/)node_modules/react-dom/";
-const RE_CAPACITOR = "(^|/)node_modules/@capacitor/";
-const RE_DOES_NOT_SHIP_DIRECTORY = "^(docs|\\.github|e2e|test|assets|scripts/mock-trakt)(/|$)";
-const RE_DOES_NOT_SHIP_MARKDOWN = "^[^/]*\\.md$";
-const RE_DOES_NOT_SHIP_FILE =
-  "^(LICENSE|playwright\\.config\\.ts|vitest\\.config\\.ts|lefthook\\.yml|cspell\\.json|dprint\\.json|biome\\.jsonc|knip\\.json|\\.jscpd\\.json|\\.dependency-cruiser\\.cjs|\\.env\\.example|\\.env\\.test|\\.env\\.mock|\\.gitignore)$";
-
+const RE_NATIVE = ["(^|/)node_modules/(expo|react-native)([-/]|$)", "^(expo|react-native)([-/]|$)"];
+const RE_DOM_ONLY = [
+  RE_REACT_DOM,
+  "(^|/)node_modules/idb-keyval/",
+  "(^|/)node_modules/radix-ui/",
+  "(^|/)node_modules/@tanstack/react-router/",
+  "(^|/)node_modules/@tanstack/react-virtual/",
+  "(^|/)node_modules/lucide-react/",
+];
 /** @type {import("dependency-cruiser").IConfiguration} */
 module.exports = {
   forbidden: [
@@ -21,98 +27,137 @@ module.exports = {
       from: {},
       to: { circular: true },
     },
-    // These patterns mirror DOES_NOT_SHIP in test/ci/release-paths.test.ts.
-    // Changes to that list require matching updates here.
-    // Known gaps: this rule is static analysis over import specifiers that
-    // dependency-cruiser can resolve. import.meta.glob(...) and
-    // new URL("...", import.meta.url) are invisible to it. Neither produces a
-    // resolvable import edge that dependency-cruiser follows, so a file matched
-    // by either idiom is never flagged, even if it points at a non-shipping
-    // path. import.meta.glob(...) is already used in
-    // src/ui/screens/settings/Settings.tsx. Also, from.path "^src/" covers only
-    // the first edge out of src. It does not cover a transitive hop through a
-    // non-src root file that imports a non-shipping path.
     {
-      name: "src-no-non-shipping-imports",
+      name: "packages-declare-their-imports",
       severity: "error",
       comment:
-        "Importing a non-shipping path into src can put it in the production bundle while mobile release paths-ignore still skips changes to it.",
-      from: { path: "^src/" },
-      to: {
-        path: [RE_DOES_NOT_SHIP_DIRECTORY, RE_DOES_NOT_SHIP_MARKDOWN, RE_DOES_NOT_SHIP_FILE],
-      },
+        "dependency-cruiser's own no-non-package-json, anchored at the packages. A package may import only what its OWN manifest declares. `nodeLinker: hoisted` (pnpm-workspace.yaml) puts every transitive dependency at the workspace root where any package can reach it undeclared, which is the strictness the default linker exists to provide and the price the native package's resolver charges for it. knip's dependency lane does not close this: react is a peerDependency of @tanstack/react-query, so it read 33 undeclared react imports in @cue/core as satisfied.",
+      from: { path: "^packages/" },
+      to: { dependencyTypes: ["npm-no-pkg", "npm-unknown", "unknown"] },
     },
     {
       name: "domain-stays-pure",
       severity: "error",
       comment:
-        "src/domain is runtime-agnostic: global fetch + zod only. No data/ui/app/platform, no react, no react-dom, no capacitor.",
-      from: { path: "^src/domain/" },
+        "The domain is runtime-agnostic: global fetch + zod only. Stated positively, as what it MAY reach rather than as a list of the directories it may not: the ban then covers a directory added to the core tomorrow instead of waiting to be amended. In-repo, the domain may reach the domain and nothing else; from npm it may take no react and no react-dom.",
+      from: { path: "^packages/core/src/domain/" },
       to: {
-        path: ["^src/(data|ui|platform|app)/", RE_REACT, RE_REACT_DOM, RE_CAPACITOR],
+        path: ["^packages/", RE_REACT, RE_REACT_DOM],
+        pathNot: "^packages/core/src/domain/",
       },
     },
     {
       name: "domain-no-node-builtins",
       severity: "error",
       comment:
-        "src/domain must not touch Node built-ins (fs/path/crypto/...); it runs in browser + native.",
-      from: { path: "^src/domain/" },
+        "The domain must not touch Node built-ins (fs/path/crypto/...); it runs in a browser and on a native engine. Kept beside the other domain rules even though core-stays-portable-node bans them across the package, because the stricter statement belongs where the domain rules are read.",
+      from: { path: "^packages/core/src/domain/" },
       to: { dependencyTypes: ["core"] },
     },
     {
       name: "data-stays-headless",
       severity: "error",
       comment:
-        "src/data (clients/repos) may import domain, but never ui/app/platform, react, or react-dom.",
-      from: { path: "^src/data/" },
-      to: { path: ["^src/(ui|app|platform)/", RE_REACT, RE_REACT_DOM] },
+        "The data layer (clients/repos) is stated the same way round: in-repo it may reach the domain, its own tree and the ports it is filled through, and nothing else. That is what keeps a repository from reaching a hook, a store or the auth layer, which the directory blacklist this replaces stopped covering the moment those trees moved into the core. From npm it may take no react and no react-dom.",
+      from: { path: "^packages/core/src/data/" },
+      to: {
+        path: ["^packages/", RE_REACT, RE_REACT_DOM],
+        pathNot: "^packages/core/src/(data|domain|ports)/",
+      },
+    },
+    {
+      name: "ports-have-no-impls",
+      severity: "error",
+      comment:
+        "A port is a seam the apps fill, so it may take value imports from the domain, from its sibling ports and from react, and nothing else. Stated that way rather than as 'types only': token-store.ts imports tokenSchema, a zod value, from domain/model/token, and five of the ports publish a React context and hook beside their interface, which is how a component reaches the injected instance. React is the injection mechanism rather than an implementation, and everything an implementation would actually need (the DOM, idb-keyval or expo) is still banned here by core-stays-portable and by biome's globals override over this package.",
+      from: { path: "^packages/core/src/ports/" },
+      to: {
+        dependencyTypesNot: ["type-only"],
+        pathNot: ["^packages/core/src/(ports|domain)/", RE_REACT],
+      },
     },
     {
-      name: "ui-no-platform-impl",
+      name: "core-stays-portable",
       severity: "error",
       comment:
-        "src/ui depends on domain/data abstractions; platform impls and the app composition root are injected, not imported directly.",
-      from: { path: "^src/ui/" },
-      to: { path: "^src/(platform|app)/" },
+        "@cue/core executes independently of its Expo host, so it takes neither DOM libraries nor React Native or Expo. Anchored at src because the package's own test suite runs on Node and reads git.",
+      from: { path: "^packages/core/src/" },
+      to: { path: [...RE_DOM_ONLY, ...RE_NATIVE] },
+    },
+    {
+      name: "core-stays-portable-node",
+      severity: "error",
+      comment:
+        "The other half of the same ban. It has to be a second rule: a `to` clause is a conjunction, so one rule carrying both the package list and dependencyTypes would read 'a module whose path matches AND which is a Node built-in', which is never true.",
+      from: { path: "^packages/core/src/" },
+      to: { dependencyTypes: ["core"] },
+    },
+    {
+      name: "queries-have-no-react",
+      severity: "error",
+      comment: "Query option factories cannot import React.",
+      from: { path: "^packages/core/src/queries/" },
+      to: { path: RE_REACT },
+    },
+    {
+      name: "core-imports-no-app",
+      severity: "error",
+      comment:
+        "The shared package imports neither app. Dependencies flow into the core and never back out, or the claim that both targets run the same code is only a claim.",
+      from: { path: "^packages/core/" },
+      to: { path: "^packages/native/" },
+    },
+    {
+      name: "native-owns-expo",
+      severity: "error",
+      comment: "Expo and React Native belong to the native app and to nothing else.",
+      from: { path: "^packages/", pathNot: "^packages/native/" },
+      to: { path: RE_NATIVE },
     },
     {
       name: "trakt-reads-stay-pooled",
       severity: "error",
       comment:
-        "src/data/trakt/endpoints.ts issues raw, unpooled GETs. Only read-budget.ts " +
+        "data/trakt/endpoints.ts issues raw, unpooled GETs. Only read-budget.ts " +
         "(the pool primitive) and pooled-endpoints.ts (its wrapper for every other " +
         "caller) may import it directly: every other read must go through a pooled " +
         "wrapper, so a read reachable from the runtime without withReadRateRetry " +
         "fails here by naming the unpooled importer, instead of only an instance test " +
         "that a mutation can dodge by pooling one caller and leaving the rest raw.",
       from: {
-        path: "^src/",
-        pathNot: "^src/data/trakt/(read-budget|pooled-endpoints)\\.ts$",
+        path: "^packages/[^/]+/src/",
+        pathNot: "^packages/core/src/data/trakt/(read-budget|pooled-endpoints)\\.ts$",
       },
-      to: { path: "^src/data/trakt/endpoints\\.ts$" },
+      to: { path: "^packages/core/src/data/trakt/endpoints\\.ts$" },
     },
     {
-      name: "capacitor-only-in-platform",
+      name: "mark-revalidation-stays-scoped",
       severity: "error",
       comment:
-        "@capacitor/* is imported ONLY in src/platform, keeping domain/data/ui/app portable and testable without native mocks.",
-      from: { path: "^src/", pathNot: "^src/platform/" },
-      to: { path: RE_CAPACITOR },
+        "query-invalidation.ts refreshes a marked show's OWN detail reads and " +
+        "deliberately leaves the Up Next aggregate alone, so a surface that calls it " +
+        "directly ticks show detail and leaves the queue row reading pre-mark " +
+        "progress. Only hooks/library-cache.ts may reach it from the hook and UI " +
+        "layers: its refreshShowProgress pairs that invalidation with the scoped " +
+        "progress read that replaces the one library entry, so a new mark surface " +
+        "fails here rather than shipping a queue that quietly stops moving.",
+      from: {
+        path: "^packages/[^/]+/(src/(hooks|queries|stores|ui|screens)|app)/",
+        pathNot: "^packages/core/src/hooks/library-cache\\.ts$",
+      },
+      to: { path: "^packages/core/src/data/query-invalidation\\.ts$" },
     },
   ],
   options: {
     doNotFollow: { path: "node_modules" },
-    // Anchor to project root: an unanchored `(^|/)dist/` also matched
-    // node_modules/@capacitor/core/dist/*, silently excluding capacitor from the
-    // graph so every capacitor ban passed.
-    exclude: { path: "^(dist|coverage|ios|android)/" },
+    exclude: { path: "^(packages/[^/]+/(dist|coverage)|coverage)/" },
     tsPreCompilationDeps: true,
-    tsConfig: { fileName: "tsconfig.json" },
     enhancedResolveOptions: {
-      // Capacitor ships only `main`/`module` (no `exports`), so an
-      // `exportsFields`-only resolver drops it from the graph entirely and every
-      // capacitor ban silently passes. Listing `mainFields` restores resolution.
+      // exportsFields is what resolves @cue/core/... at all: the package declares
+      // one wildcard subpath key and no main.
+      // preserveSymlinks defaults to false, which resolves the workspace link to
+      // its realpath under packages/core, which is what makes the anchors above
+      // match instead of node_modules.
       exportsFields: ["exports"],
       conditionNames: ["import", "require", "node", "browser", "default"],
       mainFields: ["module", "browser", "main"],

.github/dependabot.yml

@@ -10,6 +10,10 @@ updates:
     directory: /.github/actions/setup-node-pnpm
     schedule:
       interval: weekly
+  - package-ecosystem: npm
+    directory: /
+    schedule:
+      interval: weekly
   - package-ecosystem: bundler
     directory: /
     schedule: