Add provenance/attestation to embeddings build - #136
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds signed, verifiable provenance attestation to the private embeddings vector-store container image built by the embeddings workflow, and verifies that attestation (both GitHub-hosted and OCI-attached) against the expected repo/workflow/ref/commit/digest.
Changes:
- Grants OIDC + attestation-related permissions to the vectorstore build job and emits the attestation URL as a job output.
- Generates provenance using
actions/attestfor the published vectorstore image digest and records the attestation URL in the workflow summary. - Adds a follow-on job that verifies the attestation via GitHub’s attestation service and via the registry-attached bundle (
--bundle-from-oci).
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External verification
An external party can inspect the public GitHub-hosted attestation record without access to the private embeddings image: https://github.com/arm/mcp/attestations/40326751. Full artifact verification—including confirming the attestation against the actual image or its OCI-attached copy—would require read access to the private GHCR package.
SLSA scope
This establishes signed, verifiable provenance for the embeddings artifact but does not claim SLSA Build Level 3, which is not necessarily needed for this private intermediate artifact. The final released MCP image is handled separately and remains subject to the Level 3 target.
Workflow with added attestation logic ran without error: https://github.com/arm/mcp/actions/runs/31620027846.