fix(flutter): surface OAuth failure errors from callback URL - #1829
Merged
Conversation
When the OAuth failure relay deep-links back without key/secret, parse the error query param and throw AppwriteException with the real type (e.g. user_already_exists) instead of a generic invalid-response error. Fixes #1827 Related to appwrite/appwrite#13308 Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Contributor
Greptile SummaryThe PR updates Flutter’s I/O client template to surface OAuth callback failures as generated Appwrite exceptions instead of generic invalid-response errors.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or non-blocking issues identified. The new branch is limited to callbacks missing session credentials, preserves malformed and plain-string error handling, and constructs exceptions using the established generated exception argument order. Important Files Changed
Reviews (1): Last reviewed commit: "fix(flutter): surface OAuth failure erro..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an OAuth login fails (e.g.
user_already_exists), the failure relay deep-links back to the Flutter app with anerrorquery param and no sessionkey/secret. The Flutter client previously threw a generic "Invalid OAuth2 Response" exception instead of the real Appwrite error.This parses the
errorJSON from the callback URL and throwsAppwriteExceptionwith the original message, type, and code.Fixes #1827
Related to appwrite/appwrite#13308
Test plan
client_io.dartincludes the new error parsinguser_already_exists(not "Missing redirect URL" / generic invalid OAuth response)Notes
Self-hosted 1.9.6 still omits
projecton the default failure relay URL (fixed onmainin appwrite#12976). That separate server fix is required for the deep-link to reach the app whenfailureis omitted; this PR covers correct error surfacing once the callback returns.