Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mock-server/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ RUN composer install --ignore-platform-reqs --optimize-autoloader \
--no-plugins --no-scripts --prefer-dist \
`if [ "$TESTING" != "true" ]; then echo "--no-dev"; fi`

FROM phpswoole/swoole:5.1.8-php8.3-alpine as final
FROM phpswoole/swoole:6.2.1-php8.3-alpine as final

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 swoole/ide-helper dev dependency is now mismatched

mock-server/composer.json pins "swoole/ide-helper": "5.1.8" but the runtime image is now Swoole 6.2.1. The IDE helper provides stubs that mirror the actual Swoole extension API, so running it against the wrong major version means IDE type-checking and autocompletion will reflect the old 5.x surface (including APIs removed in 6.x). The composer.json "require-dev" entry should be updated to a Swoole 6-compatible IDE helper version alongside this image bump.

Prompt To Fix With AI
This is a comment left during a code review.
Path: mock-server/Dockerfile
Line: 17

Comment:
**`swoole/ide-helper` dev dependency is now mismatched**

`mock-server/composer.json` pins `"swoole/ide-helper": "5.1.8"` but the runtime image is now Swoole 6.2.1. The IDE helper provides stubs that mirror the actual Swoole extension API, so running it against the wrong major version means IDE type-checking and autocompletion will reflect the old 5.x surface (including APIs removed in 6.x). The `composer.json` `"require-dev"` entry should be updated to a Swoole 6-compatible IDE helper version alongside this image bump.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex


RUN apk add docker

Expand Down
Loading