feat: SDK update for version 27.3.0 - #362
Open
ChiragAgg5k wants to merge 2 commits into
Open
Conversation
Greptile SummaryThe PR updates the Command Line SDK to version 27.3.0.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "chore: update Command Line SDK to 27.3.0" | Re-trigger Greptile |
| --key <KEY> \ | ||
| --required false \ | ||
| --default <DEFAULT> | ||
| --default Hello World |
There was a problem hiding this comment.
Unquoted multi-word default values
The changed --default Hello World example passes Hello as the flag value and World as an unexpected positional argument, so copying this command causes Cobra to reject it. Quote the value here and in the equivalent database and TablesDB text-default examples.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/databases/update-longtext-attribute.md
Line: 7
Comment:
**Unquoted multi-word default values**
The changed `--default Hello World` example passes `Hello` as the flag value and `World` as an unexpected positional argument, so copying this command causes Cobra to reject it. Quote the value here and in the equivalent database and TablesDB text-default examples.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains updates to the SDK for version 27.3.0.
What's Changed
project update-o-auth-2-cloudflareconfigures the Cloudflare OAuth2 providerproject update-o-auth-2-resendconfigures the Resend OAuth2 providerdevno longer reloads on a touch or chmod, only when file contents changedevnow picks up files and directories created or deleted after it startedtablesdb cutover-migrationis nowtablesdb create-cutoverusers create-jwt --session-id, and the OAuth2 provider listVerification
go build ./...,go vet ./...andgo test ./...all pass on the generated tree againstsdk-for-gov7.2.0-rc.5.Dependencies
Two changes this was generated against are not merged yet:
templates/cli/go.mod.twigto v7.2.0-rc.5. rc.3 has none oftablesdb.CreateCutover,project.UpdateOAuth2Cloudflareorproject.UpdateOAuth2Resend, so the CLI does not compile against it.serviceAccountJSONon the two FCM provider endpoints typed as an object. Without it the spec publishes the param as a string andmessaging create-fcm-providerstops passing it throughapp.JSONObject, which would be an unintended change to that command. With the fix applied,internal/cmd/services/messaging.gois byte-identical tomasterhere.Once both land, regenerating from a clean checkout reproduces this tree exactly.