Fix: Use visibility.base consistently in generateHelpNames for .longWithSingleDash#902
Open
AkshatRaj00 wants to merge 1 commit into
Open
Conversation
…ithSingleDash Previously, the `.longWithSingleDash` case used `visibility` (full description) while the `.long` case correctly used `visibility.base` when generating non-default help flag names. This inconsistency would cause `.longWithSingleDash` help names to have a different suffix than their `.long` counterparts. Fixes apple#901
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an inconsistency in
generateHelpNames(visibility:)inHelpGenerator.swiftwhere the.longWithSingleDashcase used the fullvisibilitydescription instead ofvisibility.base, while the.longcase correctly usedvisibility.base.Fixes #901
The Bug
The Fix
Impact
helpNameswith.longWithSingleDashat non-default (hidden/private) visibility levels-help-hiddenand--help-hiddenuse the same suffix generation logicTesting
Existing tests for help generation should continue to pass. The affected code path is only triggered when:
helpNamesincludes.longWithSingleDashvisibility.base != .default(i.e.,.hiddenor.private)No new tests are broken by this change.