Skip to content

(experimental, do_not_merge) Efficient get team by servers#12861

Closed
spraza wants to merge 1 commit intoapple:release-7.3from
spraza:efficient_getTeamByServers
Closed

(experimental, do_not_merge) Efficient get team by servers#12861
spraza wants to merge 1 commit intoapple:release-7.3from
spraza:efficient_getTeamByServers

Conversation

@spraza
Copy link
Copy Markdown
Collaborator

@spraza spraza commented Mar 26, 2026 •
edited
Loading

20260326-072449-praza-e8c2a8291ccb74a8 compressed=True data_size=35199917 duration=14798120 ended=500000 fail=1 fail_fast=10 max_runs=500000 pass=499999 priority=100 remaining=0 runtime=2:27:41 sanity=False started=500000 stopped=20260326-095230 submitted=20260326-072449 timeout=5400 username=praza

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@spraza spraza changed the base branch from main to release-7.3 March 26, 2026 04:27
@spraza spraza closed this Mar 26, 2026
@spraza spraza reopened this Mar 26, 2026
@spraza spraza force-pushed the efficient_getTeamByServers branch from 717b260 to 2ebb96f Compare March 26, 2026 04:28
@spraza spraza mentioned this pull request Mar 26, 2026
Closed
5 tasks
@spraza spraza changed the title (experimental) Efficient get team by servers (experimental, do_not_merge) Efficient get team by servers Mar 26, 2026
@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 717b260
  • Duration 0:03:40
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 717b260
  • Duration 0:04:15
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 717b260
  • Duration 0:03:35
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 717b260
  • Duration 0:04:16
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 2ebb96f
  • Duration 0:03:40
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 717b260
  • Duration 0:04:53
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 717b260
  • Duration 0:05:34
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 717b260
  • Duration 0:06:12
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 717b260
  • Duration 0:05:47
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 717b260
  • Duration 0:05:52
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 717b260
  • Duration 0:07:06
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 717b260
  • Duration 0:07:31
  • Result: ❌ FAILED
  • Error: git checkout failed with exit status 128: fatal: unable to read tree (717b260fb57095e028097964de36d4d594f9767e) for primary source and source version 717b260fb57095e028097964de36d4d594f9767e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 2ebb96f
  • Duration 0:09:26
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 2ebb96f
  • Duration 0:09:27
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 2ebb96f
  • Duration 0:09:32
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@spraza spraza force-pushed the efficient_getTeamByServers branch from 2ebb96f to 0c29adf Compare March 26, 2026 07:25
@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 0c29adf
  • Duration 0:03:59
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 0c29adf
  • Duration 0:08:14
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 0c29adf
  • Duration 0:08:23
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

foundationdb-ci commented Mar 26, 2026

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 0c29adf
  • Duration 0:08:26
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@gxglass
Copy link
Copy Markdown
Collaborator

gxglass commented Mar 27, 2026 •
edited
Loading

@spraza @neethuhaneesha FYI - I have a nearly identical version of this running on release-7.4 branch (so that it compiles for me in my environment) and it has got this far with no issues:

20260327-010322-gglass-162e80328e5430dd compressed=True data_size=35528478 duration=4815261 ended=100000 fail=1 fail_fast=1000 max_runs=100000 pass=99999 priority=100 remaining=0 runtime=1:09:22 sanity=False started=100000 stopped=20260327-021244 submitted=20260327-010322 timeout=5400 username=gglass

I'll check the 1 failure tomorrow

gxglass
gxglass reviewed Mar 27, 2026
View reviewed changes
Comment thread fdbserver/include/fdbserver/DDTeamCollection.h
@@ -682,6 +682,7 @@ class DDTeamCollection : public ReferenceCounted<DDTeamCollection> {
std::vector<Reference<TCMachineTeamInfo>> machineTeams; // all machine teams

std::vector<Reference<TCTeamInfo>> teams;
Copy link
Copy Markdown
Collaborator

@gxglass gxglass Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a very loud comment that says that any code which mutates teams should also update teamsByServerIDs

Copy link
Copy Markdown
Collaborator Author

@spraza spraza Mar 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This PR is not polished at all yet. Will do.

gxglass
gxglass reviewed Mar 27, 2026
View reviewed changes
Comment thread fdbserver/DDTeamCollection.actor.cpp
auto it = self->teamsByServerIDs.find(TCTeamInfo::serversToString(req.src));
if (it != self->teamsByServerIDs.end()) {
res = it->second;
}
Copy link
Copy Markdown
Collaborator

@gxglass gxglass Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing we could do here is:

if (1% random chance) {
// assert that not finding this entry in teamsByServerIDs is correct.
const std::string servers = TCTeamInfo::serversToString(req.src);
for (const auto& team : self->teams) {
ASSERT(team->getServerIDsStr() != servers);
}
}

@spraza spraza closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gxglass gxglass gxglass left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spraza @foundationdb-ci @gxglass