Skip to content

ZOOKEEPER-5054: Netty client should allow every supported TLS ciphers… #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmolnar merged 1 commit into from
Oct 5, 2026
Merged

ZOOKEEPER-5054: Netty client should allow every supported TLS ciphers… #2469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
import java.security.NoSuchAlgorithmException;
import java.util.Arrays;
import java.util.List;
import java.util.Set;
import java.util.TreeSet;
import java.util.concurrent.Callable;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutionException;
Expand Down Expand Up @@ -823,27 +825,33 @@ public void testCreateSSLContext_hostnameVerificationNoCustomTrustStore(X509KeyT

@ParameterizedTest
@MethodSource("data")
public void testCreateSSLContext_ChaCha20Cipher(X509KeyType caKeyType,
public void testCreateSSLContext_AllClientCiphers(X509KeyType caKeyType,
X509KeyType certKeyType, String keyPassword, Integer paramIndex) throws Exception {
init(caKeyType, certKeyType, keyPassword, paramIndex);

// TLS_CHACHA20_POLY1305_SHA256 cipher is a mandatory cipher suite on TLSv1.3,
// so a client with default configuration must support it.
// Netty has an own list of supported ciphers, which is a subset of
// JVM's available cipher suites. A client ssl engine must support every
// cipher which is supported by the JVM.

ZKConfig zkConfig = new ZKConfig();
zkConfig.setProperty(x509Util.getSslEnabledProtocolsProperty(), "TLSv1.3");
SSLContext defaultContext = SSLContext.getInstance("TLSv1.3");
defaultContext.init(null, null, null);

String[] defaultCipherArray = defaultContext.getSupportedSSLParameters().getCipherSuites();
Set<String> defaultCipherSet = new TreeSet<>(Arrays.asList(defaultCipherArray));

try (ClientX509Util clientX509Util = new ClientX509Util()) {
SslContext context = clientX509Util.createNettySslContextForClient(zkConfig);
ZKConfig config = new ZKConfig();
config.setProperty(x509Util.getSslEnabledProtocolsProperty(), "TLSv1.3");

SslContext clientContext = clientX509Util.createNettySslContextForClient(config);

UnpooledByteBufAllocator byteBufAllocator = new UnpooledByteBufAllocator(false);
SSLEngine engine = context.newEngine(byteBufAllocator);
SSLEngine engine = clientContext.newEngine(byteBufAllocator);

String[] enabledProtocols = engine.getEnabledProtocols();
assertArrayEquals(new String[] { "TLSv1.3" }, enabledProtocols);
String[] clientCipherArray = engine.getEnabledCipherSuites();
Set<String> clientCipherSet = new TreeSet<>(Arrays.asList(clientCipherArray));

List<String> enabledCipherSuites = Arrays.asList(engine.getEnabledCipherSuites());
assertTrue(enabledCipherSuites.contains("TLS_CHACHA20_POLY1305_SHA256"));
assertEquals(defaultCipherSet, clientCipherSet);
}
}

Expand Down
Loading