You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ZOOKEEPER-4993: Lower "Attempting to delete candidate container..." logging to DEBUG - #2430
This change lowers the candidate container deletion log from INFO to DEBUG to avoid excessive log volume while preserving the constructor configuration log at INFO.
A regression test verifies that the candidate deletion message is emitted at DEBUG level.
Jenkins build #1 reached compilation and failed only in two unrelated tests: ServerCnxnFactoryTest.testShedConnections_SmallPercentageRoundsToZero{FactoryType}[2] (probabilistic 1% shedding returned 1 instead of the test expected 0) and QuorumRestartTest.testRestartingLeaderMultipleTimes (30-second leader-election timeout). The PR-specific CreateContainerTest passed in that run. Focused local validation also passes on this commit: ServerCnxnFactoryTest 10/10, QuorumRestartTest 3/3, and CreateContainerTest 14/14. No source changes are needed for PR #2430; please rerun the Jenkins check.
@anmolnar Removed the unit test as suggested. The PR now only contains the one-line log level change in ContainerManager.java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change lowers the candidate container deletion log from INFO to DEBUG to avoid excessive log volume while preserving the constructor configuration log at INFO.
A regression test verifies that the candidate deletion message is emitted at DEBUG level.
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-4993
Tests:
mvn -pl zookeeper-server -am -Dtest=CreateContainerTest -Dsurefire.failIfNoSpecifiedTests=false testmvn -pl zookeeper-server -am -DskipTests compile checkstyle:check spotbugs:checkmvn verify spotbugs:check checkstyle:check -Pfull-build -Dsurefire-forkcount=4reached 3,239 tests. It reported 7 unrelated OCSP/SSL failures inClientSSLRevocationTestandQuorumSSLTest; allCreateContainerTesttests passed.